Skip to content

Conversation

desrosj
Copy link
Member

@desrosj desrosj commented Jul 25, 2025

Proposed changes

This standardizes the Node.js setup by:

  • Introducing an .nvmrc file specifying the version of Node.js to use when working with the repository.
  • Added engines to the package.json file.

Since 22.x is the current LTS version of Node.js, 22.11.0 is used as the minimum required version since it represents the release that transitioned the version from current to LTS status. The version of npm used (10.9.0) is the version bundled with 22.11.0

The GitHub Action workflows have been updated to ensure the desired version is used for testing and releasing, however the release workflow requires newfold-labs/workflows#77 to be merged first.

This addresses PRESS0-2909 and PRESS0-2910.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

desrosj added 2 commits July 25, 2025 11:03
This standardizes the Node.js setup by:
- Introducing an `.nvmrc` file specifying the version of Node.js to use when working with the repository.
- Added `engines` to the `package.json` file.
- Ensures the same version is used consistently in GitHub Actions workflows.
@desrosj desrosj self-assigned this Jul 25, 2025
@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 15:04
@desrosj desrosj requested a review from a team as a code owner July 25, 2025 15:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the Node.js setup across the repository by establishing version requirements and updating CI workflows. The changes specify Node.js 22.11.0 as the minimum required version (current LTS) and ensure consistent tooling across development and CI environments.

  • Adds Node.js and npm version requirements to package.json
  • Creates .nvmrc file for local development version management
  • Updates GitHub Actions workflow to use Node.js 22

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Adds engines field specifying minimum Node.js 22.11.0 and npm 10.9.0 versions
.nvmrc Creates Node Version Manager file specifying Node.js version 22
.github/workflows/brand-plugin-test.yml Updates workflow to use Node.js version 22

@arunshenoy99 arunshenoy99 merged commit 18315ea into main Jul 28, 2025
5 checks passed
@arunshenoy99 arunshenoy99 deleted the standardize-node-setup branch July 28, 2025 08:33
@desrosj desrosj mentioned this pull request Jul 29, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants