Skip to content

new features were getting set to null if they didn't already exist #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2024
Merged

new features were getting set to null if they didn't already exist #3

merged 2 commits into from
May 17, 2024

Conversation

circlecube
Copy link
Member

This will use the option if it exists or the local value if not.

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube
new features were getting set to null if they didn't already exist
82cc35c 
this will use the option if it exists or the local value if not
@circlecube circlecube requested a review from wpscholar May 16, 2024 20:16
@circlecube circlecube self-assigned this May 16, 2024
wpscholar
wpscholar requested changes May 16, 2024
View reviewed changes
@circlecube @wpscholar
use default input for options get method
55d5568 
Co-authored-by: Micah Wood <micah@wpscholar.com>
@circlecube circlecube merged commit 30f5139 into main May 17, 2024
@circlecube circlecube deleted the feature/set-feature-state-initally branch May 17, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar requested changes

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @wpscholar