Skip to content

Conversation

circlecube
Copy link
Member

Proposed changes

Update api endpoints to return the values for simplicity and to account for overriding actions when attempting to enable/disable a feature.

Also, hardens endpoints to validate feature exists before accessing.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpscholar May 13, 2024 16:40
@circlecube circlecube self-assigned this May 13, 2024
@circlecube circlecube merged commit a6780ec into main May 13, 2024
@circlecube circlecube deleted the update/endpoints-to-return-isEnabled branch May 13, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant