Skip to content

Conversation

mr-vara
Copy link
Contributor

@mr-vara mr-vara commented May 4, 2025

Proposed changes

This PR adds i18n-update workflow to automate the i18n source files (.pot, .po, .php, .json) generation and updation.
See: https://jira.newfold.com/browse/PRESS11-154

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Co-authored-by: Jonathan Desrosiers <359867+desrosj@users.noreply.github.com>
@mr-vara mr-vara requested a review from desrosj May 22, 2025 14:39
Copy link
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made a few small changes:

  • Always use quotes for string values and prefer single quotes (explained over on another PR)
  • Included the change to avoid hard coding the fallback value for base_branch.

@wpscholar wpscholar merged commit 6bd0e61 into main Jun 16, 2025
6 checks passed
@wpscholar wpscholar deleted the press11-154 branch June 16, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants