Add/feature register filter #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update/features-api-state: lint fix use isEnabled to load features into localized script
since get_declared_class is proving inconsistent
wpscholar
reviewed
May 21, 2024
includes/Features.php
Outdated
| foreach ( get_declared_classes() as $class ) { | ||
| if ( is_subclass_of( $class, 'NewfoldLabs\WP\Module\Features\Feature' ) ) { | ||
| // error_log( 'NewfoldLabs\WP\Module\Features child class found: '.$class ); | ||
| $features = apply_filters( 'newfold/features/filter/register', self::$features ); |
There was a problem hiding this comment.
Suggested change
| $features = apply_filters( 'newfold/features/filter/register', self::$features ); | |
| $features = apply_filters( 'newfold/features/filter/register', [] ); |
includes/Features.php
Outdated
Comment on lines
28
to
34
| /** | ||
| * Feature Classes | ||
| * | ||
| * @var Array | ||
| */ | ||
| private static $features = array(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| /** | |
| * Feature Classes | |
| * | |
| * @var Array | |
| */ | |
| private static $features = array(); |
wpscholar
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This includes a register filter for every feature to self-register. Not sure we still need the
is_subclass_ofcheck, but doesn't hurt to have the extra check.This also includes the update I thought I'd already merged that uses the isEnabled for the js API store.
Type of Change
Checklist
Further comments