Skip to content

Add/before and after hooks #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2024
Merged

Add/before and after hooks #5

merged 2 commits into from
May 20, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Adds before and after hooks in addition to the on hook for enable and disable methods.

Also, adding an onInit hook in case anything needs to be adjusted as modules are initialized.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpscholar May 20, 2024 15:05
@circlecube circlecube self-assigned this May 20, 2024
@circlecube circlecube merged commit 0a39c3e into main May 20, 2024
@circlecube circlecube deleted the add/before-and-after-hooks branch May 20, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @wpscholar