Skip to content

Restart Onboarding Store|Site messaging fix #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

Restart Onboarding Store|Site messaging fix #508

merged 3 commits into from
Apr 22, 2025

Conversation

abhijitb
Copy link
Contributor

Proposed changes

This is a small fix for the store/site messaging which is based on the isEcommerce capability check

JIRA Ticket : https://jira.newfold.com/browse/PRESS8-358

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@abhijitb abhijitb requested a review from wpalani April 21, 2025 09:13
wpalani
wpalani approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@wpalani wpalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure that failing test is flaky as this has absolutely nothing with the failing test. Approving.

@abhijitb abhijitb merged commit a566ced into trunk Apr 22, 2025
4 of 5 checks passed
@abhijitb abhijitb deleted the fix/isecommerce-check branch April 22, 2025 11:16
@abhijitb abhijitb mentioned this pull request Apr 22, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpalani wpalani wpalani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhijitb @wpalani