Skip to content

Conversation

circlecube
Copy link
Member

Proposed changes

In looking at #355 I noticed the check_url_match method is nested inside the show_store_setup method. I'm not sure if this was intentional but I don't think it's a best practice, so I'm moving it to the class level and updating the conditional where it is called.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpscholar April 14, 2025 21:52
@circlecube circlecube merged commit e0940bc into trunk Apr 17, 2025
3 of 5 checks passed
@circlecube circlecube deleted the fix/nested-check-url-match-method branch April 17, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants