Skip to content

Add wp-json/newfold-data/v1/capabilities for pushing capabilities #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Apr 17, 2025
Merged

Add wp-json/newfold-data/v1/capabilities for pushing capabilities #100

merged 34 commits into from
Apr 17, 2025

Conversation

BrianHenryIE
Copy link
Contributor

@BrianHenryIE BrianHenryIE commented Sep 13, 2024 •
edited
Loading

Proposed changes

  • Adds a new REST endpoint wp-json/newfold-data/v1/capabilities for Hiive to push capabilities.
  • Adds SiteCapabilities::set() (overwrite) and SiteCapabilities::update() (merge)

TODO:

  • Update SiteCapabilities to stop using transients?
  • Add schema to API\Capabilities ?

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@BrianHenryIE BrianHenryIE marked this pull request as ready for review April 15, 2025 22:09
@Copilot Copilot AI review requested due to automatic review settings April 15, 2025 22:09
Copilot
Copilot AI reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • composer.json: Language not supported
  • includes/API/Capabilities.php: Language not supported
  • includes/Data.php: Language not supported
  • includes/SiteCapabilities.php: Language not supported
  • tests/phpunit/includes/DataTest.php: Language not supported
  • tests/wpunit/includes/API/CapabilitiesWPUnitTest.php: Language not supported
  • tests/wpunit/includes/EventManagerWPUnitTest.php: Language not supported
  • tests/wpunit/includes/SiteCapabilitiesWPUnitTest.php: Language not supported

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025 •
edited
Loading

Code Coverage

project coverage report 33% @ 20000d4

fralicandro
fralicandro reviewed Apr 16, 2025
View reviewed changes
alarocca130
alarocca130 reviewed Apr 17, 2025
View reviewed changes
@BrianHenryIE BrianHenryIE merged commit 19eb650 into main Apr 17, 2025
12 of 13 checks passed
@BrianHenryIE BrianHenryIE deleted the Add/cache-purge-1 branch April 17, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@wpscholar wpscholar wpscholar approved these changes

@girish-lokapure girish-lokapure Awaiting requested review from girish-lokapure

@mr-vara mr-vara Awaiting requested review from mr-vara

@alarocca130 alarocca130 Awaiting requested review from alarocca130

@fralicandro fralicandro Awaiting requested review from fralicandro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrianHenryIE @wpscholar @alarocca130 @fralicandro