Proposed changes

Seeing some evidence that many users are not properly redirecting to onboarding, and this is a likely conflict. See PRESS8-364

Currently, the logic is a bit complex since there are nested add_action hooks and a conditional nested in a callback to register the second action.

It seems that sometimes the class_exists check fails due to it being called too early, but this is tricky to test.

This moves the class_exists check into the hook method(s) and splits the actions into specific methods. It should make the state of these checks more consistent too.

In my debugging and testing, resetting a site but leaving Bluehost and Yoast active was redirecting me to Yoast even with this in place, but with these changes I was no longer being redirected to Yoast and with a fresh SSO, was redirected to BH onboarding properly.

Though, in setting up a new site, my first login was hitting BH onboarding the first time and backing out of onboarding BH was the only active plugin. I activated Yoast and performed a reset, logged out and SSOd in again, and was redirected to BH onboarding properly too.

Type of Change

Production

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update
• Refactoring / housekeeping (changes to files not directly related to functionality)

Development

• Tests
• Dependency update
• Environment update / refactoring
• Documentation Update

Video

Checklist

• I have read the CONTRIBUTING doc
• I have viewed my change in a web-browser
• Linting and tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments