Skip to content

Improve "redirections and banners" suppression #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2024
Merged

Improve "redirections and banners" suppression #2

merged 2 commits into from
Apr 23, 2024

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Apr 13, 2024

Proposed changes

This PR aims to address these 2 internal tickets:
https://jira.newfold.com/browse/PRESS0-1023
https://jira.newfold.com/browse/PRESS0-1024

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpalani wpalani requested review from circlecube and wpscholar April 13, 2024 01:44
@wpalani wpalani merged commit 4f6affd into main Apr 23, 2024
@wpalani wpalani deleted the update/improved-suppression branch April 23, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

@circlecube circlecube Awaiting requested review from circlecube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpalani @wpscholar