Skip to content

Conversation

circlecube
Copy link
Member

Proposed changes

This sets up multiple apps in the coming soon module. Thus, it rearranges some files for organization. It updates webpack to build both apps, moves each app into own directory, and updates build paths to remove the version directory. The existing src/coming-soon.js file is the main file for the Publish Modal app, and is moved to the prePublishWarning app directory.

There is a new sitePreviewPortal coming soon app that is added to a brand plugin via the portal and it also loads the portal app assets on the brand plugin screen. This is in conjunction with the new next steps app and the removal of the old coming soon component that has been loaded via the e-commerce module. In the future, this app could be reused in the dashboard widget.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

update webpack to build both apps, move each app into own dir, update paths to remove version directory, stub coming soon portal app, add portal app assets
@circlecube circlecube self-assigned this Jul 29, 2025
Copy link
Contributor

github-actions bot commented Jul 29, 2025

* main:
  Pass the correct `node-version` to test workflow.
  Upgrade Node.js to 22.x.
  Use correct Node.js version in `.npmrc` file.
  Add missing lock file entries

# Conflicts:
#	package-lock.json
@circlecube circlecube requested review from wpalani and a team July 29, 2025 20:51
@circlecube circlecube merged commit f92eac7 into main Jul 29, 2025
14 of 16 checks passed
@circlecube circlecube deleted the add/site-preview-portal-component branch July 29, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants