Skip to content

Conversation

desrosj
Copy link
Member

@desrosj desrosj commented Jul 22, 2025

Proposed changes

This upgrades Node.js to version 22.x, the active LTS version. Version 22.11.0 is used as the minimum required version since it represents the release that transitioned the version from current to LTS status. The version of npm used (10.9.0) is the version bundled with 22.11.0

This PR also includes updates to the package-lock.json file that were missed previously. These changes are a result of running npm install before making any other changes in this pull request, but should still be examined and tested carefully.

The GitHub Action workflows have been updated to ensure the desired version is used for testing and releasing, however the release workflow requires newfold-labs/workflows#77 to be merged first.

This addresses PRESS0-2911.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@desrosj desrosj self-assigned this Jul 22, 2025
@Copilot Copilot AI review requested due to automatic review settings July 22, 2025 14:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project's Node.js version from 20.x to 22.x (the active LTS version), setting the minimum required version to 22.11.0 along with npm 10.9.0. The upgrade ensures the project uses the latest stable Node.js features and security updates.

Key changes include:

  • Updated Node.js engine requirements to version 22.11.0 and npm to 10.9.0
  • Updated .nvmrc to use Node.js version 22
  • Modified GitHub Actions workflows to use Node.js version 22 for all brand plugin tests

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Updated engines field to require Node.js >=22.11.0 and npm >=10.9.0
.nvmrc Changed Node.js version from v18 to 22 for local development
.github/workflows/brand-plugin-test.yml Added node-version: '22' parameter to all brand plugin test jobs

Copy link
Contributor

@desrosj desrosj merged commit e72236e into main Jul 24, 2025
22 of 28 checks passed
@desrosj desrosj deleted the standardize-node-setup branch July 24, 2025 19:32
@desrosj desrosj mentioned this pull request Jul 29, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants