Skip to content

Conversation

desrosj
Copy link
Member

@desrosj desrosj commented Jul 22, 2025

Proposed changes

This adds a node-version as an input for the release prep workflows.

While ideally all modules and plugins use the same versions of Node.js, that's not always the case. This ensures the correct version can be passed to each workflow until PRESS0-2909 is completed, which adds an .nvmrc file to every repository.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Visual

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@desrosj desrosj requested a review from circlecube July 22, 2025 14:13
@desrosj desrosj self-assigned this Jul 22, 2025
@Copilot Copilot AI review requested due to automatic review settings July 22, 2025 14:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the flexibility of release preparation workflows by adding a configurable node-version input parameter. The change addresses the need to support different Node.js versions across modules and plugins until standardization is completed through PRESS0-2909.

  • Adds node-version input parameter to reusable release prep workflows
  • Updates Node.js version specification format for consistency
  • Standardizes input descriptions across workflows

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/reusable-plugin-prep-release.yml Adds node-version input with default '20' and updates setup-node action to use the input
.github/workflows/reusable-module-prep-release.yml Adds node-version input with default '20' and updates setup-node action to use the input
.github/workflows/module-plugin-test.yml Standardizes description and changes default from '20.x' to '20' for consistency

@desrosj
Copy link
Member Author

desrosj commented Jul 22, 2025

For an example of how the new node-version input would be used in reusable-module-prep-release.yml, see newfold-labs/wp-module-coming-soon#81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants