Run repository-defined i18n scripts in translation workflow #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch files should be minimal in size, and retaining slightly longer helps with any situations where debugging is required.
desrosj
added a commit
to newfold-labs/wp-module-performance
that referenced
this pull request
Jul 1, 2025
This adjusts the new translation workflow to account for proposed changes in newfold-labs/workflows#58 which eliminates the need for the old-style `i18n-update.yml` file.
14 tasks
circlecube
previously approved these changes
Jul 1, 2025
14 tasks
circlecube
approved these changes
Jul 1, 2025
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In #45, a new workflow was introduced to perform string translations using Azure AI. This has been merged and is working great so far after resolving a few bugs.
There are a few other workflows related to translations in the repository:
i18n-update.ymli18n-crowdin-download.ymli18n-crowdin-upload.ymlThe last two are for a service that will no longer be utilized, and eventually can be removed. The workflows that reference these two have already been updated to only run on
workflow_dispatch.The first one, however, is still used in many repositories and suffers from several shortcomings. This includes the fact that it opens a new pull request every single time it runs, which becomes overwhelming when merging multiple commits in a short period of time without the time.
The workflow runs
i18nrelated composer scripts before committing back and creating a pull request. The new, translation workflow should be updated to also run any repository-definedi18nscripts before creating or updating a pull request to avoid the need for multiple workflows.Type of Change
Production
Development
Video
Checklist
Further comments