feat(common): add force-console option to console logger #15503
+287
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Pull Request Test Coverage Report for Build b1e13942-5596-47d2-81bc-03960211f858Details
💛 - Coveralls |
yawhide
reviewed
Aug 5, 2025
| * This is useful for test environments like Jest that can buffer console calls. | ||
| * @default false | ||
| */ | ||
| forceConsole?: boolean; |
There was a problem hiding this comment.
if i dont ever instantiate this class, i won't be able to set this to true right?
can we add a config so that when i do NestFactory.create(...), i can set the forceConsole to true?
9e72cb9 to
ff81fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, ConsoleLogger always uses process.stdout.write() and process.stderr.write() for output.
This causes issues in test environments like Jest, which can buffer console.* calls but not direct stream writes. making it difficult to capture or suppress log output during tests.
Issue Number: #15483
What is the new behavior?
Added a new forceConsole option to ConsoleLoggerOptions that, when set to true, forces the logger to use console.log() and console.error() instead of process.stdout.write() and process.stderr.write().
This allows test frameworks like Jest to properly buffer and capture log output, making tests cleaner and enabling log assertion testing.
Example usage:
Does this PR introduce a breaking change?
Other information