Skip to content

docs: get namespace instance #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2024
Merged

docs: get namespace instance #2866

merged 4 commits into from
Jul 2, 2024

Conversation

verycosy
Copy link
Contributor

@verycosy verycosy commented Oct 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

When namespace options is used inside @WebSocketGateway decorator,
@WebSocketServer() will inject namespace instance instead server instance.
But it's not explained now.

What is the new behavior?

For clear explanation, I added that information.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
@verycosy verycosy requested a review from micalevisk October 6, 2023 01:25
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
@verycosy
Copy link
Contributor Author

@kamilmysliwiec If there are no problems, could you merge this pull request?

@kamilmysliwiec kamilmysliwiec merged commit d89d241 into nestjs:master Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants