Skip to content

fix implementation of janet sfx function #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2023
Merged

fix implementation of janet sfx function #2186

merged 1 commit into from
May 8, 2023

Conversation

AlecTroemel
Copy link
Contributor

  • fixed off by one typo when looking at argc for sfx note data
  • need to actually pull note, octave, and speed from sfx data if index is positive.
  • Also added some panics on invalid sfx index, and channel values

@AlecTroemel
fix implementation of janet sfx function
eb511bb 
- fixed off by one typo when looking at argc for sfx note data
- need to actually pull note, octave, and speed from sfx data if index is
  positive.
- Also added some panics on invalid sfx index, and channel values
@nesbox nesbox merged commit 552d1e1 into nesbox:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesbox nesbox nesbox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlecTroemel @nesbox