Skip to content

fix janet pmem implementation, which was completely broken. #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

fix janet pmem implementation, which was completely broken. #2171

merged 1 commit into from
May 2, 2023

Conversation

AlecTroemel
Copy link
Contributor

currently pmem is not actually setting new values, and always returns garbage.

(print (tic80/pmem 0)) # observe garbage number
(tic80/pmem 0 123)
(print (tic80/pmem 0)) # nope still garbage

@nesbox nesbox merged commit 2dcc8e9 into nesbox:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesbox nesbox nesbox approved these changes

Assignees

@AlecTroemel AlecTroemel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlecTroemel @nesbox