Skip to content

Fix counter and freq for libretro #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix counter and freq for libretro #2072

merged 1 commit into from
Jan 12, 2023

Conversation

jezze
Copy link
Contributor

@jezze jezze commented Jan 6, 2023

This is the follow up to my previous fix to make sure libretro works as well.

@jezze
Fix counter and freq for libretro
247b5a9 
This is the follow up to my previous fix to make sure libretro
works as well.
@jezze jezze mentioned this pull request Jan 6, 2023
Closed
@jezze
Copy link
Contributor Author

jezze commented Jan 6, 2023

This have been validated to work on retroarch and fixes #2065

joshgoebel
joshgoebel approved these changes Jan 7, 2023
View reviewed changes
Copy link
Collaborator

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about like what I'd expect.

@MineRobber9000
Copy link
Contributor

Wouldn't this cause the same issues we were having earlier with clock() not being wall-time (see #1904)?

@joshgoebel
Copy link
Collaborator

Oh wait, yes what is clock() in libretro here? If it's just the same old LIBc stuff then no, it won't work. We need to be counting wall time.

@nesbox nesbox merged commit c61010e into nesbox:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

@nesbox nesbox nesbox approved these changes

Assignees

@jezze jezze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jezze @MineRobber9000 @joshgoebel @nesbox