Add djgpp support #1942
Merged
Add djgpp support #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
May 28, 2022
| include(CheckCSourceCompiles) | ||
| check_c_source_compiles( | ||
| "#ifndef __MSDOS__ | ||
| #error \"Not DOS\" |
There was a problem hiding this comment.
Wait, is DJGPP a DOS compiler? Are you building TIC-80 on DOS?
There was a problem hiding this comment.
For DOS. Cross-compiling from Debian
joshgoebel
reviewed
May 28, 2022
| if(IS_DOS) | ||
| add_custom_command(TARGET tic80_libretro | ||
| POST_BUILD | ||
| COMMAND ${CMAKE_SOURCE_DIR}/build/libretro/merge_static.sh $(AR) ${CMAKE_BINARY_DIR}/lib/tic80_libretro${LIBRETRO_SUFFIX}.${LIBRETRO_EXTENSION} ${CMAKE_BINARY_DIR}/lib/tic80_libretro_partial.a ${CMAKE_BINARY_DIR}/lib/libtic80core.a ${CMAKE_BINARY_DIR}/lib/liblua.a ${CMAKE_BINARY_DIR}/lib/libblipbuf.a ${CMAKE_BINARY_DIR}/lib/libduktape.a ${CMAKE_BINARY_DIR}/lib/libwren.a ${CMAKE_BINARY_DIR}/lib/libwasm.a ${CMAKE_BINARY_DIR}/lib/libsquirrel.a ${CMAKE_BINARY_DIR}/lib/libgiflib.a ${CMAKE_BINARY_DIR}/lib/liblpeg.a ${CMAKE_BINARY_DIR}/lib/libzlib.a ${MRUBY_LIB}) |
There was a problem hiding this comment.
Why do we only need zlib on DOS?
There was a problem hiding this comment.
- dynamically linked libretro platforms don't end up in this code path
- Other statically linked ones pull in system zlib via -lz
- DOS is special that it doesn't have system or SDK-provided zlib
There was a problem hiding this comment.
Addendum: it will also be needed for NGC and Wii but they need endianness patch in first
nesbox
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main part of DJGPP support as libretro core. We also need some changes from duktape (svaarala/duktape#2472) and wren (wren-lang/wren#1090)