Skip to content

D WebAssembly binding #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2022
Merged

D WebAssembly binding #1886

merged 2 commits into from
Apr 17, 2022

Conversation

PierceNg
Copy link
Contributor

No description provided.

@joshgoebel
Copy link
Collaborator

joshgoebel commented Apr 16, 2022 •
edited
Loading

Did you start with the template from WASM-4?

https://github.com/aduros/wasm4/tree/main/cli/assets/templates/d

I don't see any of the TIC-80 memory settings, etc... all the things specified in dub.json in the WASM-4 templates... we really don't want to re-invent the wheel but use the foundation they've already built over there for dealing with these things correctly.

@PierceNg
Copy link
Contributor Author

Did you start with the template from WASM-4?

https://github.com/aduros/wasm4/tree/main/cli/assets/templates/d

I don't see any of the TIC-80 memory settings, etc... all the things specified in dub.json in the WASM-4 templates... we really don't want to re-invent the wheel but use the foundation they've already built over there for dealing with these things correctly.

Thanks for reviewing quickly. I actually didn't start from that. I'll look into it and put in what's missing.

nesbox
nesbox approved these changes Apr 17, 2022
View reviewed changes
Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@nesbox nesbox merged commit 3a4c813 into nesbox:main Apr 17, 2022
@PierceNg PierceNg deleted the d-wasm branch April 19, 2022 14:19
@joshgoebel
Copy link
Collaborator

@nesbox This wasn't really yet ready to merge. Should I have immediately moved it to draft or assigned myself as a reviewer?

@nesbox
Copy link
Owner

nesbox commented Apr 25, 2022

Oops, sorry, I think we'll move it to draft next time to avoid misunderstandings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesbox nesbox nesbox approved these changes

Assignees

@PierceNg PierceNg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PierceNg @joshgoebel @nesbox