Split up 3rd-party submodule into individual vendor submodules #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore wren Restore zlib
nesbox
approved these changes
Mar 23, 2020
Agreed. There is docs to run |
|
Also, thanks! I can completely understand its use and purpose. Just added a little bit of complexity. Hopefully taking this approach we don't lose out on some of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the 3rd-party submodule has caused some problems when updating dependencies. While the idea is sound, it makes synchronising vendor code difficult. You have to update the
3rd-partyrepository, and then update the TIC-80 submodule to reference the fork.This change splits the 3rd-party submodule into individual submodules in the
vendordirectory. The same code is checked out, so there isn't any change in how TIC-80 functions. All this does is makes updating third-party vendor code easier since you can then just update it in one place.