add neo-test projects #366
Conversation
| "isRoot": true, | ||
| "tools": { | ||
| "neo.express": { | ||
| "version": "3.5.19", |
There was a problem hiding this comment.
can you update to new versions? Same for one below.
| | ||
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.0.31903.59 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "contract", "src\contract.csproj", "{524B2C6C-4354-42E7-A911-F55D877D7F0E}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "contract-test", "test\contract-test.csproj", "{1E87FB71-E3AD-444C-884D-E511758F9E9F}" | ||
| EndProject | ||
| Global | ||
| GlobalSection(SolutionConfigurationPlatforms) = preSolution | ||
| Debug|Any CPU = Debug|Any CPU | ||
| Release|Any CPU = Release|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(SolutionProperties) = preSolution | ||
| HideSolutionNode = FALSE | ||
| EndGlobalSection | ||
| GlobalSection(ProjectConfigurationPlatforms) = postSolution | ||
| {524B2C6C-4354-42E7-A911-F55D877D7F0E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {524B2C6C-4354-42E7-A911-F55D877D7F0E}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {524B2C6C-4354-42E7-A911-F55D877D7F0E}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {524B2C6C-4354-42E7-A911-F55D877D7F0E}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {1E87FB71-E3AD-444C-884D-E511758F9E9F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {1E87FB71-E3AD-444C-884D-E511758F9E9F}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {1E87FB71-E3AD-444C-884D-E511758F9E9F}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {1E87FB71-E3AD-444C-884D-E511758F9E9F}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| EndGlobalSection | ||
| EndGlobal |
There was a problem hiding this comment.
Remove this and add to neo-express.sln in a new folder under test called samples?
There was a problem hiding this comment.
I find this directory are more like an example to show how to use the neo-test tools, even not a part of unit tests.
Maybe we should move it the root directory with a samples folder? It does not make sence to be placed here.
There was a problem hiding this comment.
Sounds good, that makes more sense.
| <NeoContractName>$(AssemblyName)</NeoContractName> | ||
| <NeoExpressBatchFile>../express.batch</NeoExpressBatchFile> | ||
| <Nullable>enable</Nullable> | ||
| <TargetFramework>net6.0</TargetFramework> |
There was a problem hiding this comment.
after tools is updated, can you change this to dotnet 7.0 or you can create a Directory.Build.props file in the test folder?
| <IsPackable>false</IsPackable> | ||
| <Nullable>enable</Nullable> | ||
| <RootNamespace>ContractTests</RootNamespace> | ||
| <TargetFramework>net6.0</TargetFramework> |
These files was contained in origin repo and seems to be used in code. I think we can keep it for now. |
samples/Directory.Build.props
Outdated
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <NeoTestVersion>3.5.17</NeoTestVersion> |
There was a problem hiding this comment.
Shouldn't we add reference to this project?
There was a problem hiding this comment.
I find this property could be used in test.yml, changing it back to non hardcoded version.
|
what i mean is, reference the project from the repo not from nuget |
It's a independent solution for using and testing the nuget package, I think it's not fit to reference other peojects directly. |
|
All tests passes. I would merge it. If any issues need to be fixed. Can be fixed in another pr. |
Relate #287.