-
Notifications
You must be signed in to change notification settings - Fork 39
Added Standalone Github Workflow & Updated to neo
3.6.2
#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also need to test on machine with no dotnet installed on it. |
@cschuchardt88 congrats on this PR! I've been waiting for this for such a LONG TIME. 👏 I will be testing on |
Hi @Liaojinghui, |
@cschuchardt88 please latest os only in another pr. strategy: |
@lock9 You mean on release? @gsmachado how do you think? |
If you want to merge it as is, ok, but I think we should try to improve it so it looks more like this in the future https://github.com/neo-project/neo-node/releases/tag/v3.6.2 It deals better with the hashes and platforms. |
@lock9 we can discuss about it. but in the meanwhile, please also check the updates in the workflows. |
I don't know why some URLs were changed but I assume that it's because we are going to use MyGet now? I really don't know. Do you know? 😅 I've tested the osx-arm64 build and it was working fine. I saw that there are other changes not related to the workflow, but they are related to the Neo 3.6.2 upgrade. I think that this change is enough for now #358 (comment) |
@lock9 |
Co-authored-by: Jimmy <jinghui@wayne.edu>
If it's a requirement, ok. It's better to do separate PRs or at least explain it on the PR. |
Why have |
It's because osx-arm64 is used by Apple M1 chips. Other manufacturers don't offer arm based cpus for computers (mostly used on mobile devices) |
ill merge this one, further issues can be fixed in another pr. |
@cschuchardt88 publish workflow error. |
@Liaojinghui |
if its added, we may need to do |
@Liaojinghui let me know when |
@cschuchardt88 @Liaojinghui guys, where's For example,
|
@gsmachado ya i think so too. but have people that think overwise. I'll add it back, because no cares this about this repo. |
I agree 100% with your comment here: #358 (comment) Developers will know what to choose from (answering the argument that there are "too many files"). The worst thing is to exclude important developer software/hardware, e.g., Add it back! 😄 |
Release Build
Download Page - https://github.com/cschuchardt88/neo-express/releases/tag/3.6.95-preview-gf56687ff2e
Change Log
Code
*.csproj
references to version 3.6.2 forneo
Neo.Cryptography.MPT
Neo.Network.RPC.RpcClient
RocksDBStore
Neo.Plugins.RpcServer
Neo.Consensus.DBFT
BinarySerializer.Serialize
parameters to reflect new version ofneo
rocksdb
Github Actions
rocksdb
)standalone.yml
releases.yml
test.yml
Someone that has
osx-x64
&arm64
please test by running commands:Windows
win-x64

win-x86

Linux
Closes #355
Closes #259
Helps #268