Skip to content

Conversation

davidzchen
Copy link
Contributor

Starting #311 with the files with least churn.

Initial cleanup with uncrustify + manual changes for edge cases that uncrustify does not handle.

Ran the files with clint to check that style errors were fixed, then validated by building and running tests.

@davidzchen
Copy link
Contributor Author

According to the style guide:

Note that when the code wraps in this example, both of the && logical AND operators are at the end of the line. This is more common in Google code, though wrapping all operators at the beginning of the line is also allowed.

I saw examples of both having them at the end as well as in the beginning and in some cases, such as macros, a mixture of both in the same expression.

I prefer keeping the operators at the end because to me it is easier to read with the terms lined up, especially in cases where there are several nested expressions.

@davidzchen
Copy link
Contributor Author

Rebased on master to see if the build issue goes away. It looked like a luarocks issue.

@tarruda
Copy link
Member

tarruda commented Mar 7, 2014

@davidzchen I'm removing hangul input in the next hour ( #317 ) can you replay this commit after its merged ?

@davidzchen
Copy link
Contributor Author

Not a problem. I have replayed my commit on master.

@tarruda
Copy link
Member

tarruda commented Mar 7, 2014

Merged, thanks

@tarruda tarruda closed this Mar 7, 2014
Grimy pushed a commit to Grimy/neovim that referenced this pull request Jan 7, 2015
[filename_completer] Append '/' to [DIR] automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants