Skip to content

fix(api): fix crash/leak with float title/footer on error #30543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix(api): fix crash/leak with float title/footer on error #30543

merged 1 commit into from
Sep 27, 2024

Conversation

zeertzjq
Copy link
Member

No description provided.

@zeertzjq zeertzjq added api libnvim, Nvim RPC API floatwin floating windows, popups, hover ci:backport release-0.10 labels Sep 27, 2024
@zeertzjq zeertzjq added this to the 0.10.2 milestone Sep 27, 2024
@zeertzjq zeertzjq changed the title fix(api): fix memory leak with float title or footer on error fix(api): fix crash/leak with float title/footer on error Sep 27, 2024
@zeertzjq zeertzjq force-pushed the float-border-leak branch 2 times, most recently from d7b6c53 to 35d8a23 Compare September 27, 2024 12:47
@zeertzjq zeertzjq marked this pull request as draft September 27, 2024 12:57
@zeertzjq zeertzjq force-pushed the float-border-leak branch 2 times, most recently from f6b0f51 to 36bd434 Compare September 27, 2024 13:31
@zeertzjq zeertzjq marked this pull request as ready for review September 27, 2024 13:31
@zeertzjq zeertzjq enabled auto-merge (squash) September 27, 2024 13:40
@zeertzjq zeertzjq merged commit f55213c into neovim:master Sep 27, 2024
31 checks passed
@zeertzjq zeertzjq deleted the float-border-leak branch September 27, 2024 14:33
@neovim-backports
Copy link

Successfully created backport PR for release-0.10:

@neovim-backports neovim-backports bot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk justinmk justinmk approved these changes

Assignees
No one assigned
Labels
api libnvim, Nvim RPC API floatwin floating windows, popups, hover
Projects
None yet
Milestone
0.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@zeertzjq @justinmk