Skip to content

[wip] clean up makefile #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ashleyh
Copy link
Contributor

@ashleyh ashleyh commented Mar 2, 2014

  • remove repeated paths
  • switch to one-step build: make
  • remove confusing dependencies of clean and deps from cmake target
  • add USE_BUNDLED_DEPS=false option for those who want it

@scott-linder
Copy link

👍 greatly simplifies things, and now clean will remove stale deps as it should.

@jszakmeister
Copy link
Contributor

I believe @rjw57 said we should be avoiding too much work in the Makefile, and the preference was going to be have CMake drive everything? IMHO, I'd like to see CMake become the de-facto system. It's really not that hard to get it up and going.

This might be useful when dealing with the bundled deps: http://www.kitware.com/media/html/BuildingExternalProjectsWithCMake2.8.html

@ashleyh
Copy link
Contributor Author

ashleyh commented Mar 3, 2014

@jszakmeister I'm all in favour of moving stuff out of the makefile but there is no harm in having a few lines which allow people to just make instead of remembering the cmake incantation. Also it doesn't make sense to leave it broken while we wait for an eventual transition to CMake.

@jszakmeister
Copy link
Contributor

I only brought it up because I thought I was doing the same thing (making things easier for folks while waiting), and was given the same feedback. More than anything, I want to make sure I understand the direction we're heading.

@ashleyh
Copy link
Contributor Author

ashleyh commented Mar 3, 2014

Somehow I missed #198 ...

@ashleyh
Copy link
Contributor Author

ashleyh commented Mar 3, 2014

@jszakmeister Fair enough, thanks.

@jszakmeister
Copy link
Contributor

Also see @tarruda's comment in #189.

@jszakmeister
Copy link
Contributor

0b2f6a0 cleans up the make file, and gets the dependencies right. Let me know if something isn't working for you.

dwb pushed a commit to dwb/neovim that referenced this pull request Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build building and installing Neovim using the provided scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants