-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
[wip] clean up makefile #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 greatly simplifies things, and now clean will remove stale deps as it should. |
I believe @rjw57 said we should be avoiding too much work in the Makefile, and the preference was going to be have CMake drive everything? IMHO, I'd like to see CMake become the de-facto system. It's really not that hard to get it up and going. This might be useful when dealing with the bundled deps: http://www.kitware.com/media/html/BuildingExternalProjectsWithCMake2.8.html |
@jszakmeister I'm all in favour of moving stuff out of the makefile but there is no harm in having a few lines which allow people to just |
I only brought it up because I thought I was doing the same thing (making things easier for folks while waiting), and was given the same feedback. More than anything, I want to make sure I understand the direction we're heading. |
Somehow I missed #198 ... |
@jszakmeister Fair enough, thanks. |
Also see @tarruda's comment in #189. |
0b2f6a0 cleans up the make file, and gets the dependencies right. Let me know if something isn't working for you. |
new python checker: pep257
make
clean
anddeps
fromcmake
targetUSE_BUNDLED_DEPS=false
option for those who want it