Skip to content

health: remove all vimscript from nvim/health #21661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2023
Merged

health: remove all vimscript from nvim/health #21661

merged 4 commits into from
Jan 16, 2023

Conversation

tjdevries
Copy link
Contributor

I'll have to do a bit more testing, but this is most of the work

@tjdevries tjdevries requested a review from justinmk January 5, 2023 16:37
@github-actions github-actions bot added the lua stdlib label Jan 5, 2023
justinmk
justinmk reviewed Jan 5, 2023
View reviewed changes
justinmk
justinmk reviewed Jan 5, 2023
View reviewed changes
@tjdevries
Copy link
Contributor Author

resolved

@tjdevries
Copy link
Contributor Author

@justinmk do i need to tag all of these functions with @private or something to make docs not fail? I'm not sure what happened there.

@tjdevries
Copy link
Contributor Author

oh nvm, it was a flaky test

@tjdevries
Copy link
Contributor Author

As far as I can tell, this should be OK

@justinmk justinmk merged commit 307efe4 into neovim:master Jan 16, 2023
@przepompownia
Copy link
Contributor

neovim/runtime/lua/nvim/health.lua

Lines 57 to 60 in 307efe4

local vimrc = (
empty(vim.env.MYVIMRC) and vim.fn.stdpath('config') .. '/init.vim' or vim.env.MYVIMRC
)
if not filereadable(vimrc) then

If init.lua exists instead of init.vim missing user config file is still reported.

@clason clason mentioned this pull request Jan 26, 2023
Merged
@zeertzjq zeertzjq mentioned this pull request Feb 5, 2023
Merged
yesean pushed a commit to yesean/neovim that referenced this pull request Mar 25, 2023
@tjdevries @yesean
health: migrate to Lua neovim#21661
e43aebf 
* refactor: remove all vimscript from nvim/health
* fixup: previous method broke if you had a folder named 'x-lua'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk justinmk justinmk left review comments

Assignees
No one assigned
Labels
lua stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjdevries @przepompownia @justinmk