decouple third-party directory from build system unless desired #198
Conversation
As noted in neovim#194, it is now the default to compile with any system-provided dependencies used by default. Move the top-level makefile to scripts/. This Makefile is now a 'compile dependencies' file which is intended to be a convenience for those that don't want to install their own software :). The 'scripts/' directory is a bit of a misnomer but I can't think of a better name.
See comments in neovim#194.
I should've caught this in testing. Sorry.
I forgot to migrate all of scripts/travis.sh. If the author of the original commit can't migrate properly, we should probably guard against similar mistakes by updating the shim.
More than a little embarassing now...
I hope this is the last one for now. Replace an incorrect call to ``make -C build`` with ``make -C ../build``.
|
The amount of fail in the last three commits shows that it is home time. Should the Travis build pass on my way home, I'll merge. |
|
@rjw57 don't worry let me handle this merge. thanks for your help :) |
|
@tarruda any objection if I take over merging this? |
|
@ashleyh Let's see what @jszakmeister thinks about this |
|
@ashleyh @tarruda I've been working on some cleanups that I think will over take this PR. The branch isn't ready for merge yet, and still a WIP, but you can see it over here: https://github.com/jszakmeister/neovim/tree/find-deps-better I have Snow Leopard, Mavericks, Debian 7.4, and a FreeBSD machine up and going. So I'd like to make sure I can build easily on all of them before putting up for merge (and after I clean up the history). Sadly, I've also discovered a couple of bugs in CMake along the way. It's definitely been challenging, but I think I'm getting close to something useful and that will build nearly everywhere. Windows support will still need some work, but I think we'll be a lot closer once it's all wrapped up. |
- There was a bug in not calling int() on the result of the first call to the omnifunc. - We need to be more resilient to badly written omnifuncs and check that the result of the second call is a list or a dict with a list, as the vim docs say the omnifunc should return on the second call. One of the two fixes probably fixes neovim#198 but since I can't repro the error, I can't be sure.
Allow file to be excluded in filetype makers
As per discussion in #194, this PR makes the use of system-provided dependencies the default method and moves the convenience scripts for compiling software in the
third-partydirectory to thescripts/directory. Thescripts/directory is becoming increasingly misnamed but that's not thefocus of this PR.
Move the build-related information from README.md into a separate INSTALL.md file to make it easier to find.
Addresses #131 by making the use of 'ninja' or 'make' entirely up to the person building the source and not necessarily encouraging either by mandating use of a Makefile. Also update the build information to give examples of using both.
The ongoing issue #154 may want to take note of this PR as it will affect the homebrew script. Add a compatibility shim top-level Makefile so that homebrew doesn't break for the moment. When #154 is closed, it may be time to remove it for good.
Update the Travis build to use the convenience scripts but in their new location.
Since the third-party compilation scripts now install everything to the (non-hidden)
third-party/dist, update the build scripts to cope.