I think you also need to port patch 8.2.3521 and 8.2.3525.

I think you also need to port patch 8.2.3521 and 8.2.3525.

...and 8.2.3528

all 8.2.3521, 8.2.3525, and 8.2.3528 should be included.

This isn't compiling and lint still needs addressing

@seandewar and I would need a help with that definition in src/nvim/options.lua. Any idea what could be the right options? I have just copied from tsr, but not sure whether it is right.

Not sure, what's the deal with the Windows build.

Not sure, what's the deal with the Windows build.

The MSVC_32 test also fails on master, so I think you can ignore it.

This PR now has merge conflicts and needs a rebase.

Fixed.

Thank you very much, @janlazo.

@mcepl Thanks for your contribution.
@seandewar @zeertzjq Thanks for your continued assistance and your attention to detail. You both made it a lot easier to review this MR.

How can I use this in my init.lua? I used to have in init.vim:

func Thesaur(findstart, base)
    if a:findstart
	let line = getline('.')
	let start = col('.') - 1
	while start > 0 && line[start - 1] =~ '\a'
	   let start -= 1
	endwhile
	return start
    else
	let res = []
	let h = ''
	for l in split(system('aiksaurus '.shellescape(a:base)), '\n')
	    if l[:3] == '=== '
	    	let h = substitute(l[4:], ' =*$', '', '')
	    elseif l[0] =~ '\a'
		call extend(res, map(split(l, ', '), {_, val -> {'word': val, 'menu': '('.h.')'}}))
	    endif
	endfor
	return res
    endif
endfunc

set thesaurusfunc=Thesaur   " use the 'thesaurusfunc' for external thesaurus

But I can't seem to work out the synax for vim.opt.thesaurusfunc in Neovim 0.7. Cheers!

I have this:

func Thesaur(findstart, base)
    if a:findstart
        return searchpos('\<', 'bnW', line('.'))[1] - 1
    endif
    let res = []
    let h = ''
    for l in systemlist('aiksaurus '.shellescape(a:base))
        if l[:3] == '=== '
        let h = '('.substitute(l[4:], ' =*$', ')', '')
        elseif l ==# 'Alphabetically similar known words are: '
        let h = "\U0001f52e"
        elseif l[0] =~ '\a' || (h ==# "\U0001f52e" && l[0] ==# "\t")
        call extend(res, map(split(substitute(l, '^\t', '', ''), ', '),
        \                    {_, val -> {'word': val, 'menu': h}}))
        endif
    endfor
    return res
endfunc

set thesaurusfunc=Thesaur

@mcepl Can you re-create that in an init.lua file, how can I define a vimscript user function and reference it?

I probably could, but it is just a waste of time. Put this into ~/.config/nvim/plugin/mythesaurus.vim and be done with it. If you can persuade me with reasonable arguments this has any disadvantages against your Lua solution, I may try to rewrite it.

@mcepl I did the following and it worked, thanks for answering. Lua solution is optimal, but I can't be bothered myself :)

vim.cmd [[
func Thesaur(findstart, base)
    if a:findstart
	let line = getline('.')
	let start = col('.') - 1
	while start > 0 && line[start - 1] =~ '\a'
	   let start -= 1
	endwhile
	return start
    else
	let res = []
	let h = ''
	for l in split(system('aiksaurus '.shellescape(a:base)), '\n')
	    if l[:3] == '=== '
	    	let h = substitute(l[4:], ' =*$', '', '')
	    elseif l[0] =~ '\a'
		call extend(res, map(split(l, ', '), {_, val -> {'word': val, 'menu': '('.h.')'}}))
	    endif
	endfor
	return res
    endif
endfunc
]]

vim.opt.thesaurusfunc = 'Thesaur'