Skip to content

doc [ci skip] #11378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2019
Merged

doc [ci skip] #11378

merged 1 commit into from
Nov 18, 2019

Conversation

justinmk
Copy link
Member

@justinmk justinmk commented Nov 12, 2019 •
edited
Loading

  • Add :help :lua-heredoc
  • Rework :help lua-commands
  • Rename if_lua.txt => lua.txt

norcalli
norcalli reviewed Nov 12, 2019
View reviewed changes
src/nvim/lua/vim.lua
@@ -167,16 +167,15 @@ end
---
--- Example: To remove ANSI color codes when pasting:
--- <pre>
--- vim.paste = (function()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be more idiomatic Lua to do

do
  local overriden = vim.paste
  vim.paste = function(lines, phase)
    ...
  end
end

This is more of a lua-style question, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to discuss that over here? #11312

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@norcalli the "js style" in this PR saves a line. But the do-end thing is good to mention somewhere, and makes sense for cases where a function isn't being defined, IMO

@justinmk justinmk mentioned this pull request Nov 16, 2019
Closed
@justinmk
doc: Lua [ci skip]
8bcacf9 
- Rework :help lua-commands
- Rename if_lua.txt => lua.txt
@justinmk justinmk changed the title WIP: doc [ci skip] doc [ci skip] Nov 18, 2019
@justinmk justinmk merged commit af53a0c into neovim:master Nov 18, 2019
@justinmk justinmk deleted the doc branch November 18, 2019 03:07
@SolaWing
Copy link
Contributor

SolaWing commented Apr 3, 2021

I find that doc declare module conflicts for runtimepath as last wins. but in my test, it's first wins.
Also, similar to runtime to load vim file, it's also first wins.

so may need to fix the doc?

Module conflicts are resolved by "last wins".  For example if both of these
are on 'runtimepath':
    runtime/lua/foo.lua
    ~/.config/nvim/lua/foo.lua
then `require('foo')` loads "~/.config/nvim/lua/foo.lua", and
"runtime/lua/foo.lua" is not used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@norcalli norcalli norcalli left review comments

@h-michael h-michael h-michael left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinmk @SolaWing @norcalli @h-michael