-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
vim-patch:8.1.0251: using full path is not supported for 'backupdir' #11269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e085aa
to
9216700
Compare
Problem: Using a full path is supported for 'directory' but not for 'backupdir'. (Mikolaj Machowski) Solution: Support 'backupdir' as well. (Christian Brabandt, closes vim/vim#179) vim/vim@b782ba4
Also lint fix
4a1d400
to
e434a78
Compare
Windows build is failing, maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after Windows build is fixed
I'd be very grateful if someone with a Windows machine would be able to correct this test. |
I don't have windows build env available. |
one can debug this by adding temporary changes and observing the result on CI: 1d5c3e6 Result:
|
Thanks @expipiplus1 Followup
|
Address changes in neovim#11269
Thanks! |
vim-patch:8.1.0251: using full path is not supported for 'backupdir'
Problem: Using a full path is supported for 'directory' but not for
'backupdir'. (Mikolaj Machowski)
Solution: Support 'backupdir' as well. (Christian Brabandt, closes vim/vim#179)
vim/vim@b782ba4
const bool kNoPrependDot
for readabilitySupersedes: #11214