Skip to content

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 28, 2019

This allows for make build/bin/nvim.

@justinmk
Copy link
Member

why?

@blueyed
Copy link
Contributor Author

blueyed commented Jun 28, 2019

Easier at least when working on the build system, but I got used to ninja -C … already - just thought it might be nice to have in general.

(It would also allow to shrink the Makefile, but I'd keep the explicitly forwarded targets for completion etc)

@blueyed blueyed changed the title Makefile: use pattern rules for build/.deps [RFC] Makefile: use pattern rules for build/.deps Jun 28, 2019
@marvim marvim added the RFC label Jun 28, 2019
@blueyed blueyed closed this Jun 28, 2019
@blueyed blueyed deleted the makefile-percent branch June 28, 2019 22:15
@blueyed blueyed restored the makefile-percent branch July 30, 2019 06:45
@blueyed blueyed reopened this Jul 30, 2019
@blueyed blueyed force-pushed the makefile-percent branch from f304ab2 to 2731e37 Compare July 30, 2019 06:47
This allows for `make build/bin/nvim`,
`make build/src/nvim/auto/funcs.generated.h` etc.
@blueyed blueyed force-pushed the makefile-percent branch from 2731e37 to 42bb495 Compare July 30, 2019 06:47
@blueyed
Copy link
Contributor Author

blueyed commented Jul 30, 2019

Re-opening: make build/src/nvim/auto/funcs.generated.h is a bit less getting in your way when debugging something else in this regard.

@blueyed blueyed merged commit 7f6ff82 into neovim:master Jul 30, 2019
@blueyed blueyed deleted the makefile-percent branch July 30, 2019 11:53
@blueyed blueyed changed the title [RFC] Makefile: use pattern rules for build/.deps Makefile: use pattern rules for build/.deps Jul 30, 2019
blueyed added a commit to blueyed/neovim that referenced this pull request Aug 4, 2019
While not doing any harm with "Unix Makefiles", they do not work there
as-is.  Therefore just do not use them then.

Followup to neovim#10366 (7f6ff82).
blueyed added a commit to blueyed/neovim that referenced this pull request Aug 4, 2019
While not doing any harm with "Unix Makefiles", they do not work there
as-is.  Therefore just do not use them then.

Followup to neovim#10366 (7f6ff82).
blueyed added a commit that referenced this pull request Aug 4, 2019
While not doing any harm with "Unix Makefiles", they do not work there
as-is.  Therefore just do not use them then.

Followup to #10366 (7f6ff82).
timeyyy pushed a commit to timeyyy/neovim that referenced this pull request Aug 9, 2019
This allows for `make build/bin/nvim`,
`make build/src/nvim/auto/funcs.generated.h` etc.
dundargoc added a commit to dundargoc/neovim that referenced this pull request Aug 27, 2024
This reverts commit 7f6ff82.

The given reasoning and usecase is unsatisfactory. While it is true that
it allows to run `make build/bin/nvim`, it can easily be recreated with
`ninja -C build bin/nvim` which does the exact same thing. This minor
convenience is not worth adding the extra code given how rare this
usecase should be.
dundargoc added a commit that referenced this pull request Aug 28, 2024
This reverts commit 7f6ff82.

The given reasoning and usecase is unsatisfactory. While it is true that
it allows to run `make build/bin/nvim`, it can easily be recreated with
`ninja -C build bin/nvim` which does the exact same thing. This minor
convenience is not worth adding the extra code given how rare this
usecase should be.
github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
This reverts commit 7f6ff82.

The given reasoning and usecase is unsatisfactory. While it is true that
it allows to run `make build/bin/nvim`, it can easily be recreated with
`ninja -C build bin/nvim` which does the exact same thing. This minor
convenience is not worth adding the extra code given how rare this
usecase should be.

(cherry picked from commit 3085c9d)
github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
This reverts commit 7f6ff82.

The given reasoning and usecase is unsatisfactory. While it is true that
it allows to run `make build/bin/nvim`, it can easily be recreated with
`ninja -C build bin/nvim` which does the exact same thing. This minor
convenience is not worth adding the extra code given how rare this
usecase should be.

(cherry picked from commit 3085c9d)
bfredl added a commit that referenced this pull request Oct 3, 2024
This is a maintainance release.

FEATURES
--------------------------------------------------------------------------------
- a3f9bd7 jumplist: allow opting out of removing unloaded buffers (#30419)

FIXES
--------------------------------------------------------------------------------
- be831a7 api: error properly with invalid field in nvim_open_win (#30078)
- 9b4e7c9 api: fix crash/leak with float title/footer on error (#30543)
- 26b72b0 api: nvim_buf_get_text() crashes with large negative column #28740
- e537379 channel: handle writing to file instead of pipe (#30520)
- 1fc09b0 column: set signcolumn width after splitting window (#30556)
- 5cb3505 completion: don't include <Lua function> in -complete= (#30209)
- 40671f1 decor: don't use separate DecorSignHighlight for url (#30096)
- 95c3fd4 decor: exclude invalid marks from meta total
- 2115745 diagnostics: don't apply extmarks to invalid lines #29321
- f31e29f diff: use mmfile_t in linematch
- 3a23149 filetype: handle .in files with no filename (#30487)
- 045afa9 float: properly find last window of tabpage (#30571)
- 006fd03 health: fix pyenv root and python exepath detect issue
- 1e1e406 health: return correct name from 'path2name()'
- 339067a lsp: avoid reusing diagnostics from different servers in actions (#30002)
- 5955ef0 lsp: don't send foreign diagnostics to servers in buf.code_action (#29501)
- e13564b lsp: handle encoding bounds in str_utfindex_enc
- f367533 lsp: handle nil bytes in strings
- b55435f lsp: handle out-of-bounds character positions #30288
- d593b20 lsp: return call hierarchy item, not the index (#30145)
- fa4bd69 lua: ignore stdout and stderr for xdg-open
- 7284400 man: avoid setting v:errmsg (#30052)
- d000c56 man: check if buffer is valid before restoring 'tagfunc' (#30180)
- b185385 regexp: fix typo in E888 error message (#30161)
- ef05c51 runtime: add remaining missing commentstrings (#30252)
- 7e15526 runtime: sync bundled treesitter queries
- ad393c1 runtime: sync bundled treesitter queries
- 316fa16 terminal: interrupt/got_int hangs terminal (#30094)
- c9d7ad4 treesitter: EditQuery shows swapfile ATTENTION #30536
- a6b2233 treesitter: escape things like `"` in omnifunc results
- 68a2259 treesitter: indent size for inspect_tree #28727
- ba47b44 treesitter: lint top-level anonymous nodes
- ee57bb5 tui: reset active attr ID when OSC 8 sequence is terminated (#29960)
- bce2364 tui: set id parameter in OSC 8 sequences (#29847)
- 4ad864d version: return nil with empty string
- d63d379 vim.ui.open: prefer xdg-open on WSL #30302
- 1f58e27 win-msi: set installer scope to machine #29895
- 28fba3b window: making float with title/footer non-float leaks memory (#30551)
- 2f3c447 window: respect hide flag of float windows when switching (#30507)
- 6a44055 fix(vim.fs): dirname() returns "." on mingw/msys2 (#30484)

VIM PATCHES
--------------------------------------------------------------------------------
- 797f524 7c8bbc6: runtime(doc): use mkdir -p to save a command
- 7550947 9.0.2149: [security]: use-after-free in exec_instructions()
- 771b3a5 9.0.2158: [security]: use-after-free in check_argument_type
- a0a95ed 9.1.0638: E1510 may happen when formatting a message for smsg() (#29907)
- 1fda01f 9.1.0647: [security] use-after-free in tagstack_clear_entry
- 05e7248 9.1.0648: [security] double-free in dialog_changed()
- 2e1f656 9.1.0653: Patch v9.1.0648 not completely right
- eec37b6 9.1.0666: assert_equal() doesn't show multibyte string correctly (#30018)
- 9f8a5cd 9.1.0667: Some other options reset curswant unnecessarily when set (#30020)
- 1ed493c 9.1.0694: matchparen is slow on a long line (#30134)
- 974447b 9.1.0707: [security]: invalid cursor position may cause a crash (#30204)
- 886a8b6 9.1.0716: resetting setcellwidth() doesn't update the screen (#30274)
- 260ac4b 9.1.0728: [security]: heap-use-after-free in garbage collection with location list user data
- b4824ed 9.1.0729: Wrong cursor-screenline when resizing window
- 4abd480 9.1.0730: Crash with cursor-screenline and narrow window
- 687c007 9.1.0753: Wrong display when typing in diff mode with 'smoothscroll' (#30614)
- 8611f4d b584117: runtime(doc): buffers can be re-used (#30300)
- b5a2d52 e2c4e07: runtime(doc): Update :help :command-complete list
- ca6f8ee ecd642a: runtime(doc): clarify, that register 1-9 will always be shifted (#29476)

REFACTOR
--------------------------------------------------------------------------------
- 6aba2f3 move some functions out of eval.c (#29964)

BUILD SYSTEM
--------------------------------------------------------------------------------
- 8d842a3 add quotes around `CMAKE_GENERATOR` variable
- e63e0a2 make makefile work on windows
- 1db8824 remove nix flakes (#28863)
- 53e3739 silence "po" noise #30469
- 9834826 work around bug in make when PATH includes cmake as dir
- 50a021e "Makefile: use pattern rules for build/.deps (#10366)"

CI
--------------------------------------------------------------------------------
- b020b66 add `needs:backport` label on backport PRs with conflict
- 9d7711a don't add reviewers for PRs created by a bot
- 6f34f07 enable automerge by default when backporting
- 2c95d48 remove "skip ci" tag
- d585f31 skip automerge step if backport failed
- b65e978 update labeler configuration and add reviewers

TESTING
--------------------------------------------------------------------------------
- d535482 api/buffer_updates_spec: prevent flakiness (#30521)
- 6a0d1ee api/window_spec: remove duplicate test (#30538)
- 61b0816 health: "test_plug/health/init.lua" completes as "test_plug"
- 2a8d80a tui_spec: prevent another case of race between paste and input (#30481)

DOCUMENTATION
--------------------------------------------------------------------------------
- b380a8f remove mention of removed parsers
- c7e943a eval: fix wrong return type of getcharsearch() (#30176)
- c2625b6 treesitter: don't quote metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants