API/UI: add nvim_input_mouse() including multigrid mouse support #9429

bfredl · 2019-01-01T11:50:18Z

Needs more tests (and likely edge cases to fix). Also docs, as far as I can see the existing <LeftMouse><2,1> format hasn't been properly documented, should probably go in ui.txt.

ref #9421

bfredl · 2019-01-05T10:44:10Z

Instead of extending the nvim_input("<LeftMouse><col,row>") format, should we introduce nvim_mouse_input(button,event,grid,row,col) API method, and deprecate the stringly format? It seems nvim_input("<LeftMouse><20,6><LeftDrag><20,5>") doesn't work (need two separate calls), so these do not work like ordinary keys anyway.

bfredl · 2019-01-13T12:58:02Z

Began nvim_mouse_input(button,event,modifier,grid,row,col) sketch (except for missing modifiers).

@justinmk first iteration will not support "queued" mouse events, it will be interactive GUI support only as nvim_input. I might do it later, but the priority now should be to make multigrid mouse work, and with a sustainable API.

bfredl · 2019-01-19T11:52:50Z

Added modifier support (and tests), it should be feature complete. (Except for mouse redraw failure, marked in tests)

bfredl · 2019-01-19T15:18:28Z

While working on this I identified that terminal_resize is not used correctly with multigrid. I will fix/refactor it in a separate PR tough, as it looks a bit complex. (like: why does it both take width as parameter and try to calculate width from windows at the same time? what does the terminal_resize(wp, 0, 0) call do, nothing?)

bfredl · 2019-01-19T15:59:37Z

Fixed the remaining error (calculate cursor pos after vertical resize).

src/nvim/api/vim.c

test/functional/ui/mouse_spec.lua

justinmk · 2019-01-19T23:41:47Z

src/nvim/api/vim.c

+///                 that the "-" separator is optional, so "C-A-", "c-a"
+///                 and "CA" can all be used to specify Ctrl+Alt+click
+/// @param grid For a client using |ui-multigrid| pass in the grid number.
+///             Other clients should pass in 0 (not 1).


what happens if a ext_multigrid client sends 0?

The difference is primarily for floats. Both a TUI-like and a multigrid client could be connected at the same time, then 0 would correspond to the TUI grid where floats have been merged in (so float clicks should be detected), while 1 is only the default grid without floats (because the client will manage the positions of floats itself). I will expand on the docs in the float PR itself.

justinmk · 2019-01-19T23:43:37Z

While working on this I identified that terminal_resize is not used correctly with multigrid. I will fix/refactor it in a separate PR tough, as it looks a bit complex. (like: why does it both take width as parameter and try to calculate width from windows at the same time? what does the terminal_resize(wp, 0, 0) call do, nothing?)

terminal_resize is in a weird state. There is at least one pending PR for it. I've also been meaning to revisit it.

bfredl · 2019-01-20T09:39:48Z

Thanks, updated.

marvim added the WIP label Jan 1, 2019

justinmk approved these changes Jan 1, 2019

View reviewed changes

bfredl mentioned this pull request Jan 1, 2019

UI extension work (tracking issue) #9421

Open

23 tasks

bfredl force-pushed the grid_mouse branch from 2d82e33 to df35d2e Compare January 5, 2019 22:48

bfredl mentioned this pull request Jan 10, 2019

[RFC] Floating windows in TUI and Remote UI #6619

Merged

bfredl force-pushed the grid_mouse branch from df35d2e to dc4ecaa Compare January 13, 2019 12:45

bfredl force-pushed the grid_mouse branch 3 times, most recently from 4e51b05 to 7808250 Compare January 19, 2019 11:47

bfredl changed the title ~~[WIP] ui: multigrid mouse support~~ API/UI: add nvim_input_mouse() including multigrid mouse support Jan 19, 2019

bfredl force-pushed the grid_mouse branch 3 times, most recently from cc6e8dd to 9b86be2 Compare January 19, 2019 15:13

This comment has been minimized.

Sign in to view