Skip to content

highlight: Fix missing .rgb_sp_color in initializers #9287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2018
Merged

highlight: Fix missing .rgb_sp_color in initializers #9287

merged 1 commit into from
Nov 30, 2018

Conversation

justinmk
Copy link
Member

@justinmk justinmk commented Nov 28, 2018 •
edited
Loading

ref #9028
ref 60f845c

gcc 7.3 / clang 5.0 doesn't warn about this even with:

add_definitions(-Wmissing-field-initializers)

@justinmk
highlight: Fix missing .rgb_sp_color in initializers
990d5b6 
terminal_get_line_attributes() had this bug for a long time, though it
likely had no effect visible to users.

ref neovim#9028
ref 60f845c
@justinmk justinmk requested a review from bfredl November 30, 2018 00:59
@justinmk justinmk merged commit 32a30d9 into neovim:master Nov 30, 2018
@justinmk justinmk deleted the hl-diff-cursorline branch November 30, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfredl bfredl bfredl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinmk @bfredl