[RFC] test: win: enable more job tests #8034
Conversation
8ca7927 to
6c2cf63
Compare
test/functional/core/job_spec.lua
Outdated
| -- Alternative sequence: | ||
| { {'notification', 'stdout', {0, {'abc\ndef'} } }, | ||
| {'notification', 'stdout', {0, {'', ''} } } | ||
| } |
There was a problem hiding this comment.
Technically we should also expect a final {'notification', 'stdout', {0, {''} } }, so in the alternative case it would have 3 chunks (I forgot to do this in one of the cases in my PR):
+ -- Alternative sequence:
+ { {'notification', 'stdout', {0, {'abc\ndef'} } },
+ {'notification', 'stdout', {0, {'', ''} } },
+ {'notification', 'stdout', {0, {''} } }
+ }
| { {'notification', '1', {'foo', 'bar', {'some text', ''}, 'stdout'} }, | ||
| }, | ||
| -- Alternative sequence: | ||
| { {'notification', '1', {'foo', 'bar', {'some text'}, 'stdout'} }, |
There was a problem hiding this comment.
Need an extra chunk since the alternative sequence didn't see the full result in the first chunk.
-- Alternative sequence:
{ {'notification', '1', {'foo', 'bar', {'some text'}, 'stdout'},
{'notification', '1', {'foo', 'bar', {'', ''}, 'stdout'} },
Similar for the other cases below. If we see a partial sequence, we should expect the rest in later messages.
88507b6 to
2fb33d1
Compare
test/functional/core/job_spec.lua
Outdated
| screen:expect([[ | ||
| | | ||
| | | ||
| 0| |
There was a problem hiding this comment.
I don't know where this 0 came from.
2afeaac to
61f13d5
Compare
ee27d13 to
cf18106
Compare
test/functional/core/job_spec.lua
Outdated
| @@ -14,6 +14,7 @@ local nvim_set = helpers.nvim_set | |||
| local expect_twostreams = helpers.expect_twostreams | |||
| local expect_msg_seq = helpers.expect_msg_seq | |||
| local Screen = require('test.functional.ui.screen') | |||
| local nvim_cat = iswin() and nvim_dir..'\\cat' or 'cat' | |||
There was a problem hiding this comment.
This should not be needed. Other tests are already using cat.exe . Though maybe they were using cmd.exe instead of powershell.
There was a problem hiding this comment.
I don't know why the flaky tests are passing. Which cat comes firsts in PATH?
|
Is |
|
Did something happen to |
21225c9 to
8b2e2de
Compare
|
Luarocks server has been unreliable this week. |
ce3b4d1 to
9ebcf16
Compare
|
Exit code for cat.exe on Windows can be 0 or 1. Perhaps running Edit: |
672e9df to
48c7d23
Compare
|
On my machine, |
|
https://help.appveyor.com/discussions/problems/12405-builds-failing-due-to-github-tls-changes |
|
Forcing curl on luarocks requires editing |
LuaRocks had planned to use curl by default long ago, but it got stalled for some reason: luarocks/luarocks#273 @hishamhm is there a way we can set |
|
install.bat doesn't support |
|
@justinmk @janlazo we can add something similar to |
@hishamhm We bundle |
|
Closing in favor of #8120 |
Continue #7412 to resolve flaky tests in
job_spec.lua.This PR modifies
shellcmdflagfor powershell to remove aliases to avoid confusion such assleep.exe(executable) andStart-Sleep(powershell built-in, doesn't accept floats).I cannot make
cat.exereliably work on Windows. I'm considering cmd.exe to testjobsend()if there's no powershell alternative tocat.exe -. Powershell hasRead-Hostand$host.UI.RawUI.ReadKey()but neither work withjobsend().