[RFC] defaults: 'fillchars' #7403
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most fonts should have these by now. Both are a significant visual improvement. - Vertical connecting bar `│` is used by tmux, pstree, Windows 7 cmd.exe and nvim-qt.exe. - Middle dot `·` works on Windows 7 cmd.exe, nvim-qt.exe.
justinmk
commented
Oct 16, 2017
| vert:c '|' vertical separators |:vsplit| | ||
| fold:c '-' filling 'foldtext' | ||
| vert:c '│' vertical separators |:vsplit| | ||
| fold:c '·' filling 'foldtext' | ||
| diff:c '-' deleted lines of the 'diff' option | ||
|
|
||
| Any one that is omitted will fall back to the default. For "stl" and |
There was a problem hiding this comment.
This doesn't work for some reason (Vim8 and Nvim), even with the old defaults. For example if I do this:
:set fillchars=diff:a
vert is set to blank, not the fill_vert default from globals.h.
There was a problem hiding this comment.
yep that 's something that is a bit strange as the defualt is returned by a function specific to the fillchar in question. I would favor defining a default right into the structure as in https://github.com/neovim/neovim/pull/6073/files#diff-bfacc6d8f849b9559c1c6cd5b79a5431R3367
|
If you like I can takeover this PR before cleaning up/trimming https://github.com/neovim/neovim/pull/6073/files |
|
@teto yes! so glad you can work on this, would really like to get it done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Tests need to be updated, but I would like to hear any objections first.)
Most fonts should have these by now. Both are a significant visual
improvement.
│is used by tmux, pstree, etc. It also works in Windows 7 cmd.exeand nvim-qt.exe.
·works on Windows 7 cmd.exe, nvim-qt.exe.