Skip to content

test: :! cat binary data, handle control chars #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2018
Merged

test: :! cat binary data, handle control chars #6713

merged 3 commits into from
Feb 7, 2018

Conversation

justinmk
Copy link
Member

Closes #5442
Closes #4142
References #6618
References #4376

@justinmk
Copy link
Member Author

justinmk commented May 10, 2017 •
edited
Loading

@ZyX-I It looks like a crashed nvim now stops the tests. Is that intentional? or maybe it always worked like that? https://travis-ci.org/neovim/neovim/jobs/230751879

@ZyX-I
Copy link
Contributor

ZyX-I commented May 10, 2017

@justinmk Functional tests? In my experience it always worked like this, rather unexpected. I did not alter the behaviour nor tried to so far. Should have something to do with luv I think.

@ZyX-I
Copy link
Contributor

ZyX-I commented May 10, 2017

I only changed how unit tests behave on crash.

@justinmk justinmk force-pushed the test branch 2 times, most recently from b9d54b8 to 861d902 Compare May 10, 2017 22:23
@justinmk
Copy link
Member Author

justinmk commented May 10, 2017 •
edited
Loading

gcc-5 m32 build fails reliably, though this was rebased onto #6618.

RUN      ]�[0m�[0m shell command :! cat a binary file #4142: -- Output to stderr:
2017/05/10 22:31:45 ERROR 11073/open_log_file:127: Couldn't open USR_LOG_FILE, logging to stderr! This may be caused by attempting to LOG() before initialization functions are called (e.g. init_homedir()).
2017/05/10 22:31:45 ERROR 11073/call_set_error:733: RPC: ch 1 was closed by the client
2017/05/10 22:32:03 ERROR 11552/open_log_file:127: Couldn't open USR_LOG_FILE, logging to stderr! This may be caused by attempting to LOG() before initialization functions are called (e.g. init_homedir()).
2017/05/10 22:32:03 ERROR 11552/call_set_error:733: RPC: ch 1 was closed by the client

@justinmk justinmk force-pushed the test branch 2 times, most recently from 483298e to e8c8c62 Compare February 6, 2018 23:41
@justinmk justinmk mentioned this pull request Feb 7, 2018
Closed
4 tasks
@justinmk justinmk changed the title test: :! can cat binary data test: :! can cat binary data, handle control chars Feb 7, 2018
@justinmk justinmk changed the title test: :! can cat binary data, handle control chars test: :! cat binary data, handle control chars Feb 7, 2018
@justinmk
test: :! print binary data, control chars
352a51e 
closes neovim#5442
closes neovim#4142
ref neovim#6618
ref neovim#4376
ref neovim#7844
ref neovim#2958
ref neovim#4338
@justinmk
UI: restore 'writedelay' feature.
ed37136 
Removed by e0e41b3, probably
unintentionally. Useful for ye olde redraw debugging.

TODO: Also delay redraw of statusline.
@justinmk
lint, minor cleanup
35a7892
@justinmk justinmk merged commit 3665281 into neovim:master Feb 7, 2018
@justinmk justinmk deleted the test branch February 7, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinmk @ZyX-I