ui: Ameliorate TUI resize bug. #6202

justinmk · 2017-03-02T00:10:45Z

It's not ideal but seems to work quite well. Only enabled for the "built-in UI" (TUI) since we haven't seen reports of the resize issue for GUIs.

Fixing the root issue is still a priority but it will take time and there are more important things to do in the near term.

References #3929 #4884 #5692 #6157

brcolow · 2017-03-02T01:04:21Z

src/nvim/main.c

@@ -429,6 +429,7 @@ int main(int argc, char **argv)
    // Stop reading from input stream, the UI layer will take over now.
    input_stop();
    ui_builtin_start();
+    do_cmdline_cmd("au VimResized * call timer_start(100, {-> execute('mode')})");


+1 for lambda

@brcolow Thanks for working on it :)

JelteF · 2017-03-02T10:11:29Z

For me this doesn't fix the resize issue

justinmk · 2017-03-02T11:51:38Z

@JelteF Could you try these variations (just enter them in the nvim command line, then do a resize):

au VimResized * call timer_start(300, {-> execute('mode')})

au VimResized * call timer_start(100, {-> execute('refresh!|mode')})

JelteF · 2017-03-02T15:05:03Z

@justinmk The first one still doesn't work and the second one gives an error:

Error detected while processing function <lambda>8:                                                                   
line    1:                                                                                                            
E492: Not an editor command: refresh!|mode

However, I tried to increase the timer of the first one a bit more, to 1000, and that worked great. You can still have a short visual glitch, but then it corrects it.

justinmk · 2017-03-02T15:13:35Z

Oops it should be redraw.

Does 500 work?

tweekmonster · 2017-03-02T15:22:55Z

Wouldn't you want to cancel any previous timers? Fast resizing might leave us with :mode spam making the screen flicker like the timer was never used.

JelteF · 2017-03-02T15:25:21Z

Nope, but 800 works for both. One thing I noticed was that when you resize while typing a : command (ex-mode?), the screen is fully cleared except for the line with the : command.

@tweekmonster that sounds reasonable.

tweekmonster · 2017-03-02T17:04:17Z

VimResized			After the Vim window was resized, thus 'lines'
				and/or 'columns' changed.  Not when starting
				up though.

Actually, if VimResized is fired when lines and columns are changed, wouldn't it mean that this hack doesn't work and it's just going by the same old randomness of the original issue? I was testing it with au VimResized * echomsg 'fixed' reltimestr(reltime()) and this seems to be the case.

Don't know if this is useful for narrowing down the issue:

diff --git a/src/nvim/screen.c b/src/nvim/screen.c
index b98e59e..cd88c0c 100644
--- a/src/nvim/screen.c
+++ b/src/nvim/screen.c
@@ -7327,6 +7327,7 @@ int number_width(win_T *wp)
 void screen_resize(int width, int height)
 {
   static int busy = FALSE;
+  ILOG("Screen resize.  Updating: %d, Busy: %d", updating_screen, busy);
 
   // Avoid recursiveness, can happen when setting the window size causes
   // another window-changed signal.

It seems that updating_screen > 1 or busy > 1 is when the TUI has problems. Ignoring both of them resizes nvim correctly each time, but eventually segfaults (which isn't surprising).

justinmk · 2017-03-02T18:04:06Z

The root cause has to do with the input queue timing. I looked at it in November, didn't go further yet.

choco · 2017-03-05T12:59:32Z

Tested the fix above and even though it works when splitting the tmux pane, when I destroy the same split pane neovim doesn't resize itself most of the times. Changing the timing doesn't seem to change this from happening, but lower timing influences the first part of the issue (when splitting)

Tranquility · 2017-03-05T17:15:21Z

I also realized that :redraw does not help. I have the problem every time a destroy a horizontal tmux pane. But the resize works correctly if a use a vertical tmux pane. Therefore the only way to redraw and for me right now is creating and directly destroying a vertical tmux pane.

oni-link · 2017-03-05T18:54:25Z

src/nvim/ui.c

+  if (updating_screen) {
+    loop_schedule(&main_loop, event_create(1, ui_refresh_event, 0));
+    return;
+  }


if block could be moved before the declarations and loop_schedule(...) could be replaced with ui_schedule_refresh().

if block could be moved before the declarations

Good point. The current placement was due to me trying different things. If it gets here, it usually happens a dozen or so times. So, I was testing the width and height to double check that it wasn't from multiple SIGWINCH events.

and loop_schedule(...) could be replaced with ui_schedule_refresh().

justinmk · 2017-03-05T19:40:40Z

Any airline users seeing an improvement from this?

choco · 2017-03-05T19:48:06Z

This doesn't solve the #4884 issue for me, with or without airline. But at least it works sometimes ( 1 out of 10 times? ), before it never worked.

tweekmonster · 2017-03-05T20:36:03Z

@justinmk I didn't notice anything different in regard to airline.

@choco Are you using the most recent changes from this PR? It sounds like you're describing the original code using timers.

I used to have the problem mentioned in that issue, but I can no longer reproduce it. This PR makes it impossible for a resize to be ignored, so if you're still having issues it must mean that nvim isn't noticing the terminal is resizing.

You cannot escape clint...

statusline still disappears in some cases, but this change is a net improvement. References neovim#3929 neovim#5692 neovim#4884 neovim#6157

choco · 2017-03-06T12:09:29Z

Yep, still having it unfortunately :( But I noticed that removing lazyredraw from my vimrc seems to fix the issue after this change. Is there any way to ignore the lazyredraw value in these resizing situations?

JelteF · 2017-03-06T14:18:37Z

This seems to fix the issue for me.

References neovim#6202 References neovim#6202 (comment) References neovim#3929 neovim#5692 neovim#4884 neovim#6157

FEATURES: bc4a2e1 help, man.vim: "outline" (TOC) feature neovim#5169 58422f1 'guicursor' works in the TUI (and sends info to UIs) neovim#6423 129f107 api: nvim_get_mode() neovim#6247 0b59f98 api/ui: externalize tabline neovim#6583 bc6d868 'listchars': `Whitespace` highlight group neovim#6367 6afa7d6 writefile() obeys 'fsync' option neovim#6427 c60e409 eval.c refactor (also improves some error messages) neovim#5119 9d200cd getcompletion("cmdline") neovim#6376 2ea7bfc terminal: Support extra arguments in 'shell'. neovim#4504 bf51102 DirChanged autocmd neovim#5928 neovim#6262 1743df8 'cpoptions': "_" flag to toggle `cw` behaviour neovim#6235 22337b1 CTRL-R omits trailing ^M when pasting to cmdline neovim#6137 0e44916 :edit allows unescaped spaces in filename neovim#6119 abdbfd2 eval: Add id() function and make printf("%p") useful neovim#6095 bdfa147 findfile(), :find, gf work in :terminal. neovim#6009 2f38ed1 providers: Disable if `g:loaded_*` exists. b5560a6 setpos() can set lowercase marks in other buffers neovim#5753 7c513d6 Throttle :! output, pulse "..." message. neovim#5396 d2e8c76 v:exiting neovim#5651 :terminal improvements neovim#6185 neovim#6142 - cursor keeps position after leaving insert-mode. - 4ceec30 Follows output only if cursor is at end of buffer. - e7bbd35 new option: 'scrollback' - fedb844 quasi-support for undo and 'modifiable' - b45ddf7 disables 'list' by default - disables 'relativenumber' by default :help now contains full API documentation at `:help api`. man.vim saw numerous improvements. Windows support: - Windows is no longer "experimental", it is fully supported. - Windows package includes a GUI, curl.exe and other utilities. "Vim 8" features: partials, lambdas, packages. FIXES: 12fc1de ops: fix i<c-r> with multi-byte text neovim#6524 dd391bf Windows: system() and friends neovim#6497 13352c0 Windows: os_get_hostname() neovim#6413 16babc6 tui: Less-noisy mouse seqs neovim#6411 3a9dd13 (vim bug) folding edge-cases neovim#6207 f6946c6 job-control: set CLOEXEC on pty processes. neovim#5986 d1afd43 rplugin: Call s:LoadRemotePlugins() on startup. 1215084 backtick-expansion works with `shell=fish` neovim#6224 e32ec03 tui: Improved behavior after resize. neovim#6202 86c2adc edit.c: CTRL-SPC: Insert previously-inserted text. neovim#6090 c318d8e b:changedtick now follows VimL rules neovim#6112 34e24cb terminal: Initialize colors in reverse order neovim#6160 e889917 undo: Don't set b_u_curhead in ex_undojoin() neovim#5869 d25649f undo: :earlier, g-: Set b_u_seq_cur correctly. (neovim#6016) 043d8ba 'Visual-mode put from @. register' neovim#5782 42c922b open_buffer(): Do `BufEnter` for directories. 50d0d89 inccommand: Preview :sub commands only after delimiter neovim#5932 1420e10 CheckHealth improvements neovim#5519 c8d5e92 jobstart(): Return -1 if cmd is not executable. neovim#5671 CHANGES: NVIM_TUI_ENABLE_CURSOR_SHAPE was removed. Use 'guicursor' instead. See https://github.com/neovim/neovim/wiki/Following-HEAD#20170402 81525dc 'mouse=a' is no longer the default. (This will probably change again after it is improved.) neovim#6022 0c1f783 defaults: 'showcmd', 'belloff', 'ruler' neovim#6087 eb0e94f api: {get,set}_option update local options as appropriate neovim#6405 bdcb2a3 "Reading from stdin..." message was removed. neovim#6298

FEATURES: bc4a2e1 help, man.vim: "outline" (TOC) feature neovim#5169 58422f1 'guicursor' works in the TUI (and sends info to UIs) neovim#6423 129f107 api: nvim_get_mode() neovim#6247 0b59f98 api/ui: externalize tabline neovim#6583 bc6d868 'listchars': `Whitespace` highlight group neovim#6367 6afa7d6 writefile() obeys 'fsync' option neovim#6427 c60e409 eval.c refactor (also improves some error messages) neovim#5119 9d200cd getcompletion("cmdline") neovim#6376 2ea7bfc terminal: Support extra arguments in 'shell'. neovim#4504 bf51102 DirChanged autocmd neovim#5928 neovim#6262 1743df8 'cpoptions': "_" flag to toggle `cw` behaviour neovim#6235 22337b1 CTRL-R omits trailing ^M when pasting to cmdline neovim#6137 0e44916 :edit allows unescaped spaces in filename neovim#6119 abdbfd2 eval: Add id() function and make printf("%p") useful neovim#6095 bdfa147 findfile(), :find, gf work in :terminal. neovim#6009 2f38ed1 providers: Disable if `g:loaded_*` exists. b5560a6 setpos() can set lowercase marks in other buffers neovim#5753 7c513d6 Throttle :! output, pulse "..." message. neovim#5396 d2e8c76 v:exiting neovim#5651 :terminal improvements neovim#6185 neovim#6142 - cursor keeps position after leaving insert-mode. - 4ceec30 Follows output only if cursor is at end of buffer. - e7bbd35 new option: 'scrollback' - fedb844 quasi-support for undo and 'modifiable' - b45ddf7 disables 'list' by default - disables 'relativenumber' by default :help now contains full API documentation at `:help api`. man.vim saw numerous improvements. Windows support: - Windows is no longer "experimental", it is fully supported. - Windows package includes a GUI, curl.exe and other utilities. "Vim 8" features: partials, lambdas. SECURITY FIXES: CVE-2017-5953 CVE-2017-6349 CVE-2017-6350 neovim#6485 CHANGES: NVIM_TUI_ENABLE_CURSOR_SHAPE was removed. Use 'guicursor' instead. See https://github.com/neovim/neovim/wiki/Following-HEAD#20170402 81525dc 'mouse=a' is no longer the default. (This will probably change again after it is improved.) neovim#6022 0c1f783 defaults: 'showcmd', 'belloff', 'ruler' neovim#6087 eb0e94f api: {get,set}_option update local options as appropriate neovim#6405 bdcb2a3 "Reading from stdin..." message was removed. neovim#6298 FIXES: 12fc1de ops: fix i<c-r> with multi-byte text neovim#6524 dd391bf Windows: system() and friends neovim#6497 13352c0 Windows: os_get_hostname() neovim#6413 16babc6 tui: Less-noisy mouse seqs neovim#6411 3a9dd13 (vim bug) folding edge-cases neovim#6207 f6946c6 job-control: set CLOEXEC on pty processes. neovim#5986 d1afd43 rplugin: Call s:LoadRemotePlugins() on startup. 1215084 backtick-expansion works with `shell=fish` neovim#6224 e32ec03 tui: Improved behavior after resize. neovim#6202 86c2adc edit.c: CTRL-SPC: Insert previously-inserted text. neovim#6090 c318d8e b:changedtick now follows VimL rules neovim#6112 34e24cb terminal: Initialize colors in reverse order neovim#6160 e889917 undo: Don't set b_u_curhead in ex_undojoin() neovim#5869 d25649f undo: :earlier, g-: Set b_u_seq_cur correctly. (neovim#6016) 043d8ba 'Visual-mode put from @. register' neovim#5782 42c922b open_buffer(): Do `BufEnter` for directories. 50d0d89 inccommand: Preview :sub commands only after delimiter neovim#5932 1420e10 CheckHealth improvements neovim#5519 c8d5e92 jobstart(): Return -1 if cmd is not executable. neovim#5671

References neovim#6202 References neovim#6202 (comment) References neovim#3929 neovim#5692 neovim#4884 neovim#6157 References neovim#5866

Could also try `do_redraw = true` instead of save/restore `p_lz`, but the nice thing about save/restore of `p_lz` is that it is "atomic". The semantics of `do_redraw` are not clear to me. Closes neovim#4884 References neovim#6202 References neovim#6202 (comment) References neovim#3929 neovim#5692 neovim#6157 References neovim#5866

justinmk mentioned this pull request Mar 2, 2017

Crash when spawning new window alongside neovim in an xfce terminal under i3 #5692

Closed

brcolow reviewed Mar 2, 2017

View reviewed changes

justinmk changed the title ~~startup: Hack around TUI resize bug.~~ ui: Fix TUI resize bug. Mar 5, 2017

justinmk force-pushed the tui-resize-hack branch 2 times, most recently from ccc38d9 to 68367d4 Compare March 5, 2017 18:18

oni-link reviewed Mar 5, 2017

View reviewed changes

justinmk force-pushed the tui-resize-hack branch from 68367d4 to 98a7156 Compare March 5, 2017 19:26

justinmk and others added 2 commits March 5, 2017 22:17

lint

a568816

You cannot escape clint...

ui: Fix TUI resize bug

6777b6e

statusline still disappears in some cases, but this change is a net improvement. References neovim#3929 neovim#5692 neovim#4884 neovim#6157

justinmk force-pushed the tui-resize-hack branch from 98a7156 to 6777b6e Compare March 5, 2017 21:18

justinmk changed the title ~~ui: Fix TUI resize bug.~~ ui: Ameliorate TUI resize bug. Mar 5, 2017

justinmk merged commit e32ec03 into neovim:master Mar 5, 2017

justinmk deleted the tui-resize-hack branch March 5, 2017 22:24

justinmk added a commit to justinmk/neovim that referenced this pull request Mar 11, 2017

ui: Reset 'lazyredraw' during ui_refresh.

a663ce3

References neovim#6202 References neovim#6202 (comment) References neovim#3929 neovim#5692 neovim#4884 neovim#6157

justinmk mentioned this pull request Mar 11, 2017

ui: Reset 'lazyredraw' during ui_refresh. #6259

Merged

justinmk mentioned this pull request Mar 27, 2017

Neovim not resizing after closing iterm2 nightly split #3378

Closed

justinmk mentioned this pull request May 1, 2017

NVIM v0.2.0 #6634

Merged

justinmk added a commit to justinmk/neovim that referenced this pull request Aug 14, 2017

ui: disable 'lazyredraw' during ui_refresh.

f59b8b1

References neovim#6202 References neovim#6202 (comment) References neovim#3929 neovim#5692 neovim#4884 neovim#6157 References neovim#5866

justinmk mentioned this pull request Nov 23, 2017

Regression with (un)maximizing Neovim in a terminal window #3385

Closed

justinmk mentioned this pull request Mar 25, 2018

make <CTRL-L> map to :mode by default #6152

Closed

Uh oh!

ui: Ameliorate TUI resize bug. #6202

ui: Ameliorate TUI resize bug. #6202

Uh oh!

Conversation

justinmk commented Mar 2, 2017

Uh oh!

brcolow Mar 2, 2017

Choose a reason for hiding this comment

Uh oh!

justinmk Mar 2, 2017

Choose a reason for hiding this comment

Uh oh!

JelteF commented Mar 2, 2017

Uh oh!

justinmk commented Mar 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JelteF commented Mar 2, 2017

Uh oh!

justinmk commented Mar 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tweekmonster commented Mar 2, 2017

Uh oh!

JelteF commented Mar 2, 2017

Uh oh!

tweekmonster commented Mar 2, 2017

Uh oh!

justinmk commented Mar 2, 2017

Uh oh!

choco commented Mar 5, 2017

Uh oh!

Tranquility commented Mar 5, 2017

Uh oh!

oni-link Mar 5, 2017

Choose a reason for hiding this comment

Uh oh!

tweekmonster Mar 5, 2017

Choose a reason for hiding this comment

Uh oh!

justinmk commented Mar 5, 2017

Uh oh!

choco commented Mar 5, 2017

Uh oh!

tweekmonster commented Mar 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

choco commented Mar 6, 2017

Uh oh!

JelteF commented Mar 6, 2017

Uh oh!

Uh oh!

justinmk commented Mar 2, 2017 •

edited

Loading

justinmk commented Mar 2, 2017 •

edited

Loading

tweekmonster commented Mar 5, 2017 •

edited

Loading