Skip to content

Conversation

teto
Copy link
Member

@teto teto commented Feb 28, 2017

Early WIP: it kinda works.

Goal of the PR is to be able to set the signcolulmn width (currently stuck with 2 cells).
Follow up of #5802.

It adds a variable signcolumnwidth that indicates the signcolumn width when signcolumn==yes and the maximum width when signcolumn=auto.

So to test, I usually run LC_ALL=C make && ./build/bin/nvim -S ~/test_signs.vim ~/zaza:
with test_signs.vim:

:sign define a text=a
:sign define z text=z
:sign place 22 line=1 name=neomake_err buffer=1
:sign place 23 line=1 name=a buffer=1
:sign place 24 line=1 name=neomake_info buffer=1
:sign place 25 line=1 name=z buffer=1
:sign place 26 line=1 name=neomake_warn buffer=1

and then sets

set signcolumn=auto
set signcolumnwidth=6 

2017-02-28-182352_478x342_scrot

teto added 9 commits February 28, 2017 18:07
This commit does not change the behavior but change in column size centralized so it opens up possibilities (like adjusting signcolumn width depending on the maximum number of signs on a line).

The returned value is limited by the size of the `extra` tab in win_line
(currently allows for 18 ANSII characters).
Problem is it defaults to 0 :s

... hopefully we can understand it as a max
@justinmk
Copy link
Member

justinmk commented Feb 24, 2019

I think #9295 covers this, please re-open if not.

@justinmk justinmk closed this Mar 3, 2019
@justinmk justinmk removed the WIP label Mar 3, 2019
@teto teto deleted the var_signs branch April 20, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants