Skip to content

Added curl support when downloading dependancies #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added curl support when downloading dependancies #61

wants to merge 1 commit into from

Conversation

tbelaire
Copy link
Contributor

Check for the existence of curl after failing to find wget.

Note that I ended up removing the quotes around $url
when referencing it in the call to wget, since urls can't have spaces
anyways, and the correct quoting was messy. Also I added a few
more local declarations to the variables.

To test, I did

rm -r .deps
make clean
make cmake
make

And it worked.

@tbelaire
Added curl support and one test
493dbe7 
Now it checks for the existance of curl after
failing to find wget.

Note that I ended up removing the quotes around $url
when referencing it in the call to wget, since urls can't have spaces
anyways, and the correct quoting was messy.

To test, I did

    rm -r .deps
    make clean
    make cmake
    make

And it worked.
@tbelaire tbelaire mentioned this pull request Feb 22, 2014
Closed
@davidgranstrom
Copy link

@tbelaire Great! Can confirm that your test is working here as well.

@tbelaire tbelaire mentioned this pull request Feb 23, 2014
Closed
@ashleyh
Copy link
Contributor

ashleyh commented Feb 23, 2014

Thanks for doing this but I am waiting to see the outcome of #13 before merging.

@ashleyh
Copy link
Contributor

ashleyh commented Feb 25, 2014

Done, thanks

@ashleyh ashleyh closed this Feb 25, 2014
@tbelaire tbelaire mentioned this pull request Feb 27, 2014
Closed
@blueyed blueyed mentioned this pull request Feb 7, 2017
Merged
dwb pushed a commit to dwb/neovim that referenced this pull request Feb 21, 2017
Signs refactor. Fixes neovim#61, neovim#48, neovim#60
c998504 
Sets the stage to fix neovim#46. Not sure why it isn't working at the moment, but I
wanted to get this merge in because a lot has changed and it seems like nothing
new is breaking (after using it personally for about a week).
dwb pushed a commit to dwb/neovim that referenced this pull request Feb 21, 2017
@benekastah
Merge pull request neovim#77 from benekastah/signs
bc45d16 
Signs refactor. Fixes neovim#61, neovim#48, neovim#60

Sets the stage to fix neovim#46. Not sure why it isn't working at the moment, but I
wanted to get this merge in because a lot has changed and it seems like nothing
new is breaking (after using it personally for about a week).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbelaire @davidgranstrom @ashleyh