What harm does it cause to leave this option in the code? And what benefit does it provide to make it a noop?

See #537

Basically it's just obsolete and therefore dead code that should be removed. I'm a regular in #vim for a long time and I can't recall even one time where someone asked about this option.

@tarruda suggested that we make it a no-op, like 'compatible', so plugins using it won't fail because of an error. But then the plugin could be doing funky things because of a false-positive value or so.

Anyway, it's so long deprecated that I'd think it can be safely removed all at once.

@mhinz Nice work! Could you take a look at the docs and update/remove it from there as well?

Also, maybe we should display some kind of error message if textmode is encountered, something like "textmode is removed from neovim, use fileformat instead (see :h 'fileformat')". What do you think?

Thanks!

As I said, it's mainly made a no-op because of (very old) plugins and compatibility. Those won't care about helpful suggestions. :P

LGTM. It's OK to make obsolete options noop at this point.

But then the plugin could be doing funky things because of a false-positive value or so.
Anyway, it's so long deprecated that I'd think it can be safely removed all at once.

Now that you put it like this, I also think we should remove. It's better if plugins using the option throw an error than being mistaken by false positives. Since it's already deprecated by vim, any plugins that use it should also be considered deprecated right?

Yup, I'd say so. Shoud I create a new PR for it or just push the changes and change this PR title?

Just change this PR and rebase/squash the commits

Hmm, Travis outputted for both builds:

No output has been received in the last 10 minutes, this potentially
indicates a stalled build or something wrong with the build itself.

The build has been terminated

But it builds just fine locally. I'll just force push again to trigger another Travis run.

It seems to be an issue when building msgpack, I'm gonna investigate

That actually is after msgpack is built/installed, seems to be another "luarocks strikes again" issue :)

I'm not sure how luarocks is working, but luarocks.org isn't responding either. :]

@mhinz the build should work if you rebase on master

👍 thanks

#537 can get closed now.