Skip to content

shada: Save current cursor position before saving jumps #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 7, 2017
Merged

shada: Save current cursor position before saving jumps #5079

merged 6 commits into from
Jan 7, 2017

Conversation

ZyX-I
Copy link
Contributor

@ZyX-I ZyX-I commented Jul 17, 2016

@ZyX-I ZyX-I added the bug label Jul 17, 2016
@ZyX-I ZyX-I force-pushed the shada-save-current-pos branch from 0ddb743 to 34358c2 Compare July 17, 2016 16:52
@justinmk
Copy link
Member

Some shada tests are failing.

@justinmk
Copy link
Member

justinmk commented Jan 4, 2017 •
edited
Loading

@ZyX-I Does this address #5875 / #3472 ?

@ZyX-I
Copy link
Contributor Author

ZyX-I commented Jan 4, 2017

This does not deal with numbered marks.

@ZyX-I ZyX-I force-pushed the shada-save-current-pos branch from 34358c2 to ac50971 Compare January 4, 2017 15:14
@justinmk
Copy link
Member

justinmk commented Jan 5, 2017 •
edited
Loading 

error: always_inline function might not be inlinable [-Werror=attributes]
 static ShadaEntry shada_get_buflist(khash_t(bufset) *const removable_bufs)

ZyX-I added 2 commits January 6, 2017 01:47
@ZyX-I
shada: Mark ALWAYS_INLINE function as inline
10d9c6d
@ZyX-I
clint: Add more exceptions to “space after a cast” rule
a1cce83 
Python does not allow branching here, complaining that look-behind is not 
fixed-width.
@justinmk
Copy link
Member

justinmk commented Jan 6, 2017

QB failure looks like an intermittent unrelated failure:

Uncaught Error: ...ated/.deps/usr/share/lua/5.1/nvim/msgpack_rpc_stream.lua:84: invalid msgpack-rpc  string
18:31:20,166 WARN  -     test/functional/ex_cmds/global_spec.lua:53: in function <test/functional/ex_cmds/global_spec.lua:49

It's failing here (note: that test was changed, now lives in ctrl_c_spec.lua). I wonder if nvim printed something to the stdout pipe or died for some reason.

@ZyX-I ZyX-I mentioned this pull request Jan 7, 2017
Merged
@justinmk justinmk merged commit d2f16d5 into neovim:master Jan 7, 2017
@ZyX-I ZyX-I deleted the shada-save-current-pos branch January 7, 2017 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZyX-I @justinmk