@ashleyh for filesystem functions yes, we'll use blocking versions. Theres no reason for using non-blocking functions since we aren't writing a highly concurrent network server.

For reading input from stdin(and pipes when job control is implemented) we are going to use libuv streams in a background thread that fills a static buffer. The main thread reads from that buffer (mch_inchar) in a blocking way by using mutexes and condition variables.

I already started working in the 'libuv-io-saved' branch but currently some tests are failing(test 49 and 61). Here is what I have done: https://github.com/neovim/neovim/blob/libuv-io-saved/src/io.c

@susulaird feel free to dig and send pull requests to that topic branch

Initial idea is to migrate each mch_* function from os_unix.c to io.c with libuv implementations. Vim currently those mch_* functions for talking to the OS.

Theoretically, reimplementing those functions on top of libuv should do the job, in practice that doesn't work due to some modules skipping those functions and making the system calls directly.

Another thing we need to refactor urgently is signal handling. Here's an idea of how vim currently does it:

void sigint_handler() {
  got_int = 1;
}

void a() {
// doing something
if (got_int) // got_int is a global flag that is set when SIGINT was received
  // do something
}

void b() {
// doing something
if (got_int)
  // do something
}

Checks like the above happen all over the place resulting in some serious spaghetti code. The fastest way I found to fix this is to handle signals in the same way keys are handled, signals will be intercepted by the event loop which will put special sequences in the input buffer. That way we can remove all those repetitive tests and deal with signals at top level loops. For an idea of how that may be implemented see vim's job control patch.

Before starting to migrate the fs functions, we still need to fix the bugs causing those tests to fail.

Uh oh!

Port most OS calls to libuv #3

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions