improve IsColorTerminal windows support #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hermannm Thanks once again for the excellent PR. We could cut a new release now, or do you have any other changes in mind coming soon? |
|
@neilotoole I don't have anything more in mind for now, so if you'd like to push a |
|
Tagged and released 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IsColorTerminalimplementation for WindowsENABLE_VIRTUAL_TERMINAL_PROCESSINGflag, to see if ANSI colors are supported (https://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences)ENABLE_PROCESSED_OUTPUT, since that should be set whenENABLE_VIRTUAL_TERMINAL_PROCESSINGis set (https://learn.microsoft.com/en-us/windows/console/setconsolemode#parameters)libuv(used by Node.js)IsCygwinTerminalcheckwindows.GetConsoleModealready fails for such terminals, so the behavior is the same (tested this on my Windows machine)go-isattyin favor ofgolang.org/x/term- I would say that golang.org dependencies are preferablego.modandjsoncolor.go