fix: Fix URL Search Parameter with falsy value gets omitted #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #1282 by ensuring that falsy values, such as 0, are correctly encoded into query string parameters rather than being omitted.
- Added tests to verify that objects containing a 0 value are properly serialized.
- Modified the filter logic in flattenForRailsQueryString to include falsy values except for undefined.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/adapters/serializers/serializer-native-impl.spec.ts | Added a test case for serializing a 0 value in querystring format |
| src/adapters/serializers/flatten.ts | Revised filter logic to ensure 0 is not omitted in querystring serialization |
| src/adapters/serializers/flatten.spec.ts | Added a test case to check for proper encoding of an object with a value of 0 |
Comments suppressed due to low confidence (1)
src/adapters/serializers/flatten.ts:49
- Changing the filter to use 'v != undefined' correctly retains 0, but it will also include null values. Confirm if null values should be included in the querystring or if an additional check should be applied.
.filter(([, v]) => v != undefined)
commit: |
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1282