feat: Promote Symbol.dispose for WebSocketSubscription to a stable API #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR promotes Symbol.dispose for WebSocketSubscription from an experimental API to stable status by removing experimental workarounds and documentation. Key changes include:
- Removal of fallback assignments for Symbol.dispose and Symbol.asyncDispose in test utility files.
- Deletion of the experimental documentation comments in WebSocketSubscription.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test-utils/jest-setup-after-env-unit.ts | Removed experimental Symbol assignments |
| test-utils/jest-environment.ts | Removed experimental Symbol assignments from globals |
| src/adapters/ws/web-socket-subscription.ts | Removed experimental API comments to mark stable usage |
commit: |
size-limit report 📦
|
b38b61c to
abd385a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.