Skip to content

Format unquotted attributes #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

Format unquotted attributes #41

merged 1 commit into from
Jan 10, 2024

Conversation

x4d3
Copy link
Contributor

@x4d3 x4d3 commented Jan 6, 2024 •
edited
Loading

It looks reasonable to skip them as they should not need any transformations.

Fix #40

@elia
Copy link
Member

elia commented Jan 8, 2024

Thanks for fixing this @x4d3, ideally I'd like to add missing quotes and normalize that way, you think you can update the PR with that change?

@x4d3
Copy link
Contributor Author

x4d3 commented Jan 10, 2024

@elia your wish is my command :) I've addressed your comment.

@x4d3 x4d3 changed the title Skip formatting unquotted attributes Format unquotted attributes Jan 10, 2024
elia
elia approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@elia elia merged commit 0dfaace into nebulab:main Jan 10, 2024
@elia
Copy link
Member

elia commented Jan 10, 2024

Released as 0.7.1 🎉 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unquoted single char values are not handled properly
2 participants
@x4d3 @elia