Skip to content

Add option to set width to the CLI #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

Add option to set width to the CLI #13

merged 1 commit into from
Jan 18, 2023

Conversation

elia
Copy link
Member

@elia elia commented Jan 17, 2023

Fixes #2.

@elia elia self-assigned this Jan 17, 2023
@elia elia requested a review from nbelzer January 17, 2023 12:58
@elia elia mentioned this pull request Jan 17, 2023
Closed
nbelzer
nbelzer approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@nbelzer nbelzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. If you have the time I think it would be valuable to add a spec that tests a different line_width param to the ERB::Formatter as we don't seem to have one.

@nbelzer nbelzer merged commit 17cef4d into main Jan 18, 2023
@nbelzer nbelzer deleted the elia/print-width branch January 18, 2023 09:52
@nbelzer nbelzer mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nbelzer nbelzer nbelzer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@elia elia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format with print width
2 participants
@elia @nbelzer